fix: scope list validation to step 3 in compose wizard - #91
Merged
Conversation
The list selection validation was incorrectly triggering on all form submissions, including step 1 where no list selector exists. Now the validation only runs when #mskd-lists-select is present (step 3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking Continue in step 1 of the compose wizard, users see the alert "Please select at least one list" - even though list selection only exists in step 3.
Root Cause
The JavaScript validation used a generic
$('form').on('submit')which triggered on ALL forms. Since#mskd-lists-selectdoesn't exist in step 1,$('#mskd-lists-select').val()returnsnull, incorrectly triggering the validation.Fix
Added a check for the list selector's existence before validating:
Testing