Skip to content

fix: scope list validation to step 3 in compose wizard - #91

Merged
katsar0v merged 1 commit into
mainfrom
fix/wizard-step1-list-validation
Dec 19, 2025
Merged

fix: scope list validation to step 3 in compose wizard#91
katsar0v merged 1 commit into
mainfrom
fix/wizard-step1-list-validation

Conversation

@katsar0v

Copy link
Copy Markdown
Owner

Problem

When clicking Continue in step 1 of the compose wizard, users see the alert "Please select at least one list" - even though list selection only exists in step 3.

Root Cause

The JavaScript validation used a generic $('form').on('submit') which triggered on ALL forms. Since #mskd-lists-select doesn't exist in step 1, $('#mskd-lists-select').val() returns null, incorrectly triggering the validation.

Fix

Added a check for the list selector's existence before validating:

var $listsSelect = $('#mskd-lists-select');
if ($listsSelect.length > 0) {
    // validate only when element exists
}

Testing

  • Step 1: Click Continue → navigates to step 2 (no alert)
  • Step 3: Click Send without list → shows validation alert

The list selection validation was incorrectly triggering on all form
submissions, including step 1 where no list selector exists. Now the
validation only runs when #mskd-lists-select is present (step 3).
@katsar0v
katsar0v merged commit 8059126 into main Dec 19, 2025
5 checks passed
@katsar0v
katsar0v deleted the fix/wizard-step1-list-validation branch December 19, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant