Extend inactive subscriber deletion to include unsubscribed status - #97
Merged
Conversation
The "delete inactive subscribers" button now also deletes subscribers with 'unsubscribed' status, in addition to 'inactive' (unconfirmed). Updated SQL query, success/empty messages, button description, and confirmation dialog to reflect the expanded scope. https://claude.ai/code/session_01YHiwtqwU8em5guVPZA2ikB
Updated Bulgarian (bg_BG) and German (de_DE) .po and .mo files to reflect the new msgid strings and translated descriptions/messages for the expanded delete action that now covers inactive, unconfirmed, and unsubscribed subscribers. https://claude.ai/code/session_01YHiwtqwU8em5guVPZA2ikB
- MO files: Recompile using wp i18n make-mo (WP-CLI) to match exact binary output expected by the Translations CI check - PHP 8.1 tests: Fix undefined variable $class (should be $class_name) in test bootstrap autoloader; PHP 8.1 converts undefined variable warnings to exceptions via convertWarningsToExceptions in phpunit.xml - CHANGELOG: Add entry for the delete unsubscribed subscribers change and the bootstrap fix https://claude.ai/code/session_01YHiwtqwU8em5guVPZA2ikB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the subscriber deletion feature to include unsubscribed subscribers in addition to inactive (unconfirmed) subscribers. This change affects the database query, user-facing messages, and documentation strings across the codebase.
Key Changes
delete_inactive()method inclass-subscriber-service.phpto query for subscribers with eitherinactiveORunsubscribedstatus instead of justinactiveImplementation Details
WHERE status IN (%s, %s)with both 'inactive' and 'unsubscribed' valueshttps://claude.ai/code/session_01YHiwtqwU8em5guVPZA2ikB