Android X support#364
Closed
mathiasscheffe wants to merge 4 commits into
Closed
Conversation
Use AndroidX library for FileProvider
With Android11, queryintentactivities api doesn't return a list of email client unless the intent is set in AndroidManifest. This is because of Android 11 package visibility feature. reference - https://devblogs.microsoft.com/xamarin/android-11-package-visibility/
Add action:sento intent to plugin.xml
Collaborator
|
Hi @mathiasscheffe it seems in this PR you propose 2 changes, but the change you propose for Does the change in If so, could you redo the PR to ignore the first part? Thanks |
jfoclpf
reviewed
Nov 21, 2021
| </provider> | ||
| </config-file> | ||
|
|
||
| <config-file target="AndroidManifest.xml" parent="/*"> |
Collaborator
There was a problem hiding this comment.
this was already done with PR #368 , so you should ignore
jfoclpf
reviewed
Nov 21, 2021
| package de.appplant.cordova.emailcomposer; | ||
|
|
||
| import android.support.v4.content.FileProvider; | ||
| import androidx.core.content.FileProvider; |
Collaborator
There was a problem hiding this comment.
According to what I read, this is still valid
https://stackoverflow.com/questions/48534293/android-support-v4-content-fileprovider-not-found
But I would like to be sure. Do you confirm?
Collaborator
There was a problem hiding this comment.
Many other forks are using this change, such as
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to android X support libraries in order to enable use of this plugin under cordova-android@10.0.0