Implement Accessing Export Memory #33
Conversation
Still unsure about the name match_extern_type
Follows the rust bindings choice for just one type. Clean up the duplicated code as a result. Dependent code needs to change accordingly.
|
I'll take a look at the documentation later. I agree that the rust specific part might not be appropriate. |
|
Seems like a dependency issue occured in the meantime. I'll have a loom at it later :) |
There was a problem hiding this comment.
Thanks, followed up some comments.
Seems like a dependency issue occured in the meantime.
yes indeed.. looks like one of transitive dependency of wasmtime now requires newer version of Cargo to build it. Weirdly I could not reproduce it until I clear local crates cache.
Anyway, I managed to pass the build by upgrading rust nightly version, so you can also PR to update the rust version we're using in CI to pass the build: https://github.com/kawamuray/wasmtime-java/blob/master/.github/workflows/ci.yml#L24
| @@ -8,18 +8,8 @@ | |||
| @Accessors(fluent = true) | |||
| @AllArgsConstructor(access = AccessLevel.PACKAGE) | |||
| public class ImportType { | |||
There was a problem hiding this comment.
I think we don't even need ImportType and ExportType separately. They share exactly the same definition, so we just need to rename this class to ExternType and use it for exports too?
| * All WebAssembly instances and items will be attached to and refer to a Store. For example instances, functions, | ||
| * globals, and tables are all attached to a Store. Instances are created by instantiating a Module within a Store. | ||
| * <p> | ||
| * A Store is intended to be a short-lived object in a program. No form of GC is implemented at this time so once an |
There was a problem hiding this comment.
This document has a rust-java gap problems too. The notion of "GC", "drop", and so on.
Besides implementing the above capabilities (similar to the imports PR #31 ), this also adds some documentation from the Rust Binding.