Fix SQLite Query class docstring#3519
Open
FoxRLY wants to merge 3 commits into
Open
Conversation
Changed docstring to reflect actual query object
Change SQLLite to official SQLite name to prevent confusion
Contributor
|
am I right to say that this is a breaking change? |
Author
|
@AzisK guess it is. Maybe making these 2 changes as separate PRs would be better if breaking changes are not appreciated |
Contributor
|
Breaking changes are never appreciated by the users. However, sometimes it is the way. Would need to bump the major version then |
Author
|
Ok, I'll change the scope of the PR to only fix docstring so major version change is not required. PR with name changes will come later |
FoxRLY
changed the title
This reverts commit 127c126.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLLiteto conventionalSQLiteI don't know the reason why
SQLiteobjects are calledSQLLite- maybe it's something important or contributes to backwards compatability. Because of that second commit is seen as optional by me