Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

Unclear message on incorrect credentials#280

Open
iamkunalb wants to merge 5 commits into
kblincoe:masterfrom
iamkunalb:218-Unclear-message-on-incorrect-credentials
Open

Unclear message on incorrect credentials#280
iamkunalb wants to merge 5 commits into
kblincoe:masterfrom
iamkunalb:218-Unclear-message-on-incorrect-credentials

Conversation

@iamkunalb

Copy link
Copy Markdown
Collaborator

Fixed unclear pop up message on incorrect credentials

Test:

  • Proceed to sign in with incorrect credentials
  • Click sign in
  • Text boxes should go red to notify user
    or
  • Proceed to sign in with no credentials
  • Click sign in
  • Text boxes should go red to notify user

@0608jennylee 0608jennylee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The submodules, Pong-Game, VisualGit_SE701_2019_3, and dummy, should be removed from this pull request.
  • The image pexels-photo-414612 does not seem to used, this should be removed.

@0608jennylee 0608jennylee mentioned this pull request Apr 8, 2019

@0608jennylee 0608jennylee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodules, Pong-Game, VisualGit_SE701_2019_3, and dummy, should be removed from this pull request.
The image pexels-photo-414612 does not seem to used, this should be removed.
theres some changes that dont seem to do anything, could you fix this, thanks.

Comment thread app/misc/repo.ts Outdated
Comment thread app/components/authenticate/authenticate.component.html Outdated
@0608jennylee 0608jennylee self-requested a review April 11, 2019 01:01
@0608jennylee 0608jennylee dismissed their stale review April 11, 2019 01:02

outdated comments - resolved by latest commit

@0608jennylee 0608jennylee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks good, but it seems that you have merge conflicts with master, I am unable to test your code, due to these conflicts, could you correct this as well, thanks

@0608jennylee

Copy link
Copy Markdown
Collaborator

@iamkunalb is this working on your system, for some reason when I test it I just get a bunch of errors and nothing loads
image
image

also the transcript compiler is getting some compiler issues from the file you have made modifications to, I'm not sure if this is causing the page to not load
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants