This repository was archived by the owner on Feb 25, 2020. It is now read-only.
Can now enable or disable console log#332
Open
Amal97 wants to merge 2 commits into
Open
Conversation
Collaborator
|
I think the issue is focused more on the fact that having a constant stream of console logs makes it hard to see any other console logs that you might add when debugging, so disabling logs completely won't really help in that case? Maybe instead you could try adding various flags (based either on files, or functionality) that allow developers to disable certain parts of the logging rather than all of it - you could just add some if statements before each log command. P.S. Also, I feel like the UI for debugging options should ideally be hidden from normal users, or at least be put somewhere out of the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #188
Test:
Ignore my branch name it should have been 188 instead of 309