Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

Can now enable or disable console log#332

Open
Amal97 wants to merge 2 commits into
kblincoe:masterfrom
Amal97:309-disable-console-log
Open

Can now enable or disable console log#332
Amal97 wants to merge 2 commits into
kblincoe:masterfrom
Amal97:309-disable-console-log

Conversation

@Amal97

@Amal97 Amal97 commented Apr 11, 2019

Copy link
Copy Markdown
Collaborator

Fix issue #188

Test:

  1. Open VisualGit
  2. Go in to inspection mode ("Ctr Shift I" for windows)
  3. You will see all the console logs printing
  4. Check "Turn Console Log Off"
  5. You shouldn't be able to see any console log print outs

image

Ignore my branch name it should have been 188 instead of 309

@ktam069

ktam069 commented Apr 11, 2019

Copy link
Copy Markdown
Collaborator

I think the issue is focused more on the fact that having a constant stream of console logs makes it hard to see any other console logs that you might add when debugging, so disabling logs completely won't really help in that case?

Maybe instead you could try adding various flags (based either on files, or functionality) that allow developers to disable certain parts of the logging rather than all of it - you could just add some if statements before each log command.

P.S. Also, I feel like the UI for debugging options should ideally be hidden from normal users, or at least be put somewhere out of the way.

@Amal97 Amal97 changed the title Can now enable or diable console log Can now enable or disable console log Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants