Conversation
pst
force-pushed
the
refactor
branch
5 times, most recently
from
746638a to
4f67fa7
Compare
Member
Author
|
This is a dead-end. Having the two sets of modules allows consuming the node pool module from the cluster module without the data sources in the non _modules one. Keeping the node pool module split in two and having only the cluster module be a single one seems possible, but it's easier to keep them uniform. Passing every variable through two modules seems a necessary price to pay. With the other PR migrating the cluster modules from map(string) to map(object) for var.configuration, at least the entire locals block can be removed. So that makes maintenance easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.