Add scaleway#361
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class Scaleway (scw) support to the Kubestack framework by introducing a Scaleway cluster module + node-pool submodule, wiring them into the integration tests and quickstart templates, and extending the dev OCI image to include the Scaleway CLI.
Changes:
- Add new
scaleway/clustermodule andscaleway/cluster/node-poolsubmodule, including kubeconfig and default ingress support. - Extend test and quickstart configurations to provision a Scaleway “zero” cluster and providers.
- Add Scaleway CLI to the OCI image and update
Makefiletest targets/env passthrough to include Scaleway.
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/versions.tf | Add Scaleway provider requirement for test configuration. |
| tests/scw_zero_providers.tf | Add Scaleway + Kubernetes/Kustomization provider wiring for scw test cluster. |
| tests/scw_zero_node_pools.tf | Add test node-pool module usage for Scaleway. |
| tests/scw_zero_cluster.tf | Add test cluster module usage for Scaleway cluster. |
| scaleway/cluster/versions.tf | Define required providers and Terraform/OpenTofu version constraint for Scaleway cluster module. |
| scaleway/cluster/variables.tf | Define inheritance-based configuration schema for Scaleway cluster module. |
| scaleway/cluster/outputs.tf | Expose standard cluster outputs including kubeconfig. |
| scaleway/cluster/node_pool.tf | Provision default node pool via the node-pool submodule. |
| scaleway/cluster/network.tf | Provision Scaleway VPC + private network for the cluster. |
| scaleway/cluster/moved.tf | Introduce moved.tf placeholder for new module. |
| scaleway/cluster/main.tf | Implement Scaleway Kubernetes cluster resource + metadata/config integration. |
| scaleway/cluster/kubeconfig.tf | Generate kubeconfig YAML from Scaleway cluster attributes. |
| scaleway/cluster/ingress.tf | Implement default ingress IP + DNS zone/records in Scaleway. |
| scaleway/cluster/node-pool/versions.tf | Define required providers and version constraint for node-pool module. |
| scaleway/cluster/node-pool/variables.tf | Define inheritance-based configuration schema for Scaleway node pools. |
| scaleway/cluster/node-pool/outputs.tf | Output merged config and node-pool identifier(s). |
| scaleway/cluster/node-pool/moved.tf | Introduce moved.tf placeholder for new node-pool module. |
| scaleway/cluster/node-pool/main.tf | Implement per-zone scaleway_k8s_pool creation + tagging/taints. |
| quickstart/src/configurations/scw/versions.tf | New Scaleway quickstart: provider requirements and version constraint. |
| quickstart/src/configurations/scw/scw_zero_providers.tf | New Scaleway quickstart: provider configuration pattern. |
| quickstart/src/configurations/scw/scw_zero_cluster.tf | New Scaleway quickstart: example cluster configuration. |
| quickstart/src/configurations/scw/README.md | New Scaleway quickstart documentation. |
| quickstart/src/configurations/scw/Dockerfile.loc | New Scaleway quickstart local dev container Dockerfile. |
| quickstart/src/configurations/scw/Dockerfile | New Scaleway quickstart Dockerfile using the -scw image variant. |
| quickstart/src/configurations/scw/.gitignore | New Scaleway quickstart gitignore for local state/user dir. |
| quickstart/src/configurations/multi-cloud/versions.tf | Add Scaleway provider requirement to multi-cloud quickstart. |
| quickstart/src/configurations/multi-cloud/scw_zero_providers.tf | Add Scaleway providers to multi-cloud quickstart. |
| quickstart/src/configurations/multi-cloud/scw_zero_cluster.tf | Add Scaleway cluster module usage to multi-cloud quickstart. |
| oci/Dockerfile | Add Scaleway CLI builder stage and scw image variant; include scw CLI in multi-cloud image too. |
| aws/cluster/node_pool.tf | Add/adjust default node-pool submodule invocation for AWS cluster module. |
| Makefile | Include module.scw_zero in targeted test apply and pass KBST_AUTH_SCW into the test container. |
| AGENTS.md | Expand and formalize framework development guidelines and module conventions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
da43fbf to
019195a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.