Add preconditions for required configuration attrs#367
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces lifecycle precondition checks to enforce required configuration attributes across multiple cloud provider cluster/node-pool modules, and updates tests/quickstarts/CI to supply newly required attributes.
Changes:
- Add
lifecycle { precondition { ... } }guards for required configuration attributes in AWS, AzureRM, Google, and Scaleway modules. - Update AKS test configs and AKS quickstart configs to include
availability_zones(with CIsedinjection support). - Remove now-resolved “missing preconditions” entries from
DEVIATIONS.mdand document the quickstart placeholder + CI injection pattern inAGENTS.md.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/aks_zero_node_pools.tf | Adds availability_zones to node pool test config. |
| tests/aks_zero_cluster.tf | Adds availability_zones to cluster test config. |
| scaleway/cluster/node-pool/main.tf | Adds preconditions for required node-pool attrs; adjusts for_each expression. |
| scaleway/cluster/main.tf | Adds preconditions for region and cluster_version. |
| google/cluster/node-pool/main.tf | Adds preconditions for required node-pool attrs. |
| google/cluster/main.tf | Adds preconditions for required cluster attrs. |
| azurerm/cluster/node-pool/main.tf | Adds preconditions for required node-pool attrs; refactors lifecycle placement. |
| azurerm/cluster/main.tf | Adds preconditions for required cluster/default node pool attrs. |
| aws/cluster/node_pool.tf | Passes availability_zones from cluster config into default node-pool submodule. |
| aws/cluster/node-pool/main.tf | Adds preconditions for required node-pool attrs; refactors lifecycle placement. |
| aws/cluster/main.tf | Adds precondition for cluster_availability_zones. |
| quickstart/src/configurations/multi-cloud/aks_zero_cluster.tf | Adds availability_zones placeholder + docs. |
| quickstart/src/configurations/aks/aks_zero_cluster.tf | Adds availability_zones placeholder + docs. |
| .github/workflows/main.yml | Adds CI sed injection for AKS availability_zones. |
| DEVIATIONS.md | Removes entries that are addressed by new preconditions. |
| AGENTS.md | Documents obligations and standardizes precondition error message format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5ed14aa to
ec4557e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.