Skip to content

Add preconditions for required configuration attrs#367

Merged
pst merged 1 commit into
masterfrom
preconditions
Mar 2, 2026
Merged

Add preconditions for required configuration attrs#367
pst merged 1 commit into
masterfrom
preconditions

Conversation

@pst

@pst pst commented Mar 2, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces lifecycle precondition checks to enforce required configuration attributes across multiple cloud provider cluster/node-pool modules, and updates tests/quickstarts/CI to supply newly required attributes.

Changes:

  • Add lifecycle { precondition { ... } } guards for required configuration attributes in AWS, AzureRM, Google, and Scaleway modules.
  • Update AKS test configs and AKS quickstart configs to include availability_zones (with CI sed injection support).
  • Remove now-resolved “missing preconditions” entries from DEVIATIONS.md and document the quickstart placeholder + CI injection pattern in AGENTS.md.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/aks_zero_node_pools.tf Adds availability_zones to node pool test config.
tests/aks_zero_cluster.tf Adds availability_zones to cluster test config.
scaleway/cluster/node-pool/main.tf Adds preconditions for required node-pool attrs; adjusts for_each expression.
scaleway/cluster/main.tf Adds preconditions for region and cluster_version.
google/cluster/node-pool/main.tf Adds preconditions for required node-pool attrs.
google/cluster/main.tf Adds preconditions for required cluster attrs.
azurerm/cluster/node-pool/main.tf Adds preconditions for required node-pool attrs; refactors lifecycle placement.
azurerm/cluster/main.tf Adds preconditions for required cluster/default node pool attrs.
aws/cluster/node_pool.tf Passes availability_zones from cluster config into default node-pool submodule.
aws/cluster/node-pool/main.tf Adds preconditions for required node-pool attrs; refactors lifecycle placement.
aws/cluster/main.tf Adds precondition for cluster_availability_zones.
quickstart/src/configurations/multi-cloud/aks_zero_cluster.tf Adds availability_zones placeholder + docs.
quickstart/src/configurations/aks/aks_zero_cluster.tf Adds availability_zones placeholder + docs.
.github/workflows/main.yml Adds CI sed injection for AKS availability_zones.
DEVIATIONS.md Removes entries that are addressed by new preconditions.
AGENTS.md Documents obligations and standardizes precondition error message format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scaleway/cluster/node-pool/main.tf
Comment thread scaleway/cluster/node-pool/main.tf
Comment thread AGENTS.md
Comment thread aws/cluster/main.tf
Comment thread google/cluster/main.tf
Comment thread google/cluster/node-pool/main.tf
Comment thread azurerm/cluster/main.tf
Comment thread scaleway/cluster/main.tf
Comment thread aws/cluster/node-pool/main.tf
Comment thread azurerm/cluster/node-pool/main.tf
@pst pst force-pushed the preconditions branch 2 times, most recently from 5ed14aa to ec4557e Compare March 2, 2026 10:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread quickstart/src/configurations/scw/scw_zero_cluster.tf
Comment thread .github/workflows/main.yml
Comment thread scaleway/cluster/node-pool/main.tf
Comment thread quickstart/src/configurations/multi-cloud/scw_zero_cluster.tf
@pst pst merged commit da92976 into master Mar 2, 2026
21 checks passed
@pst pst deleted the preconditions branch March 2, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants