add sockets_url to socket key api - #180
Open
lepelog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use case it that I want to support bingosync and also other instances at the same time, so the user just drops in the complete bingosync link with room code so I can make a request to the
join-roomapi endpoint to get the socket key.However, there is currently no way I'm aware of to get the url the sockets server is hosted at.
The only (really hacky) solution would be to mimic the normal user signin process and then grab the sockets url from the html with a regex or something, which is definitely not ideal.
So instead just send the
sockets_urlalong with thesocket_key.