fix(agents): align permissionMode acceptEdits across plugin and project layers#732
Merged
Merged
Conversation
…ct layers permissionMode: acceptEdits was declared only in the project copies of the documentation-writer and refactor-assistant write agents; the plugin copies omitted it, so the same write agents prompted on every edit in the standalone plugin distribution. Add the field to both plugin copies to align the layers, and document in CUSTOM_EXTENSIONS.md that permissionMode is kept identical across layers (it was previously missing from the intended-layer-diff list, making the gap a silent capability drift).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
plugin/agents/의 두 write 에이전트(documentation-writer,refactor-assistant) frontmatter에permissionMode: acceptEdits를 추가하여project/.claude/agents/사본과 정렬하고,docs/CUSTOM_EXTENSIONS.md에 이 필드가 두 레이어에서 동일하게 유지됨을 명문화했다.배경
permissionMode는 런타임이 honor하는 공식 frontmatter 필드다. 그러나permissionMode: acceptEdits가project/.claude/agents/documentation-writer.md와refactor-assistant.md에만 선언되어 있고, 대응하는plugin/agents/사본에는 누락되어 있었다.docs/CUSTOM_EXTENSIONS.md의 의도된 레이어 차이 목록은color와temperature만 명시하고permissionMode는 언급하지 않으므로, 이 누락은 의도된 차이가 아니라 조용한 권한 드리프트(silent capability drift)였다. 그 결과 standalone plugin 배포본에서는 동일한 write 에이전트가 매 편집마다 권한 프롬프트를 받아 무인·배치 문서/리팩터링 작업 흐름이 끊겼다. 또한scripts/check_agents.sh는 frontmatter를 제거하고 본문만 비교하므로 이 차이가 CI에서 잡히지 않고 출하되었다.구현
plugin/agents/documentation-writer.mdfrontmatter의effort: high다음에permissionMode: acceptEdits추가.plugin/agents/refactor-assistant.mdfrontmatter에 동일하게 추가.docs/CUSTOM_EXTENSIONS.md의 레이어-차이 설명 문장에permissionMode: acceptEdits가 두 write 에이전트에 대해 양 레이어 동일하게 유지됨을 명문화.검증
grep "permissionMode" plugin/agents/{documentation-writer,refactor-assistant}.md→ 각 1건(effort: high다음 줄)scripts/check_agents.sh→check_agents: OK (8 agent pairs in sync)(본문 parity 영향 없음; frontmatter는 비교 대상 아님)비고
refactor-assistant는 직전 PR(#731, 옵션 B)에서tools를 변경하지 않고 본문만 재서술했으므로, 이 PR에서acceptEdits를 추가해도 "미검증 자동편집 + 자동 셸 실행" 동시 개방 문제는 발생하지 않는다.후속(epic #726의 P2):
scripts/check_agents.sh에permissionMode/tools같은 동작 필드의 레이어 간 정합성 검사를 추가하여(의도된 차이인color는 allowlist) 재발을 CI에서 차단하는 작업이 남아 있다.Closes #729
Part of #726