Skip to content

fix(agents): clarify test-strategist skeletons are report output not file writes#736

Merged
kcenon merged 1 commit into
developfrom
fix/issue-734-test-strategist-skeleton-output
Jun 13, 2026
Merged

fix(agents): clarify test-strategist skeletons are report output not file writes#736
kcenon merged 1 commit into
developfrom
fix/issue-734-test-strategist-skeleton-output

Conversation

@kcenon

@kcenon kcenon commented Jun 13, 2026

Copy link
Copy Markdown
Owner

변경 내용

test-strategist 에이전트 정의(2개 파일)의 description과 본문 3곳을 수정하여, 테스트 스켈레톤이 디스크에 기록되는 파일이 아니라 report 코드블록으로 제시됨을 명확히 했다.

배경

test-strategist는 description("generates test skeletons")과 본문("Generate test file scaffolding")에서 테스트 스켈레톤·scaffolding 생성을 핵심 기능으로 내세운다. 그러나 tools는 read-only(Read, Grep, Glob, BashWrite/Edit 없음)라 실제로 파일을 디스크에 쓸 수 없다. 기능 약속과 부여된 권한이 어긋나, 사용자가 파일 생성을 기대하면 오해를 부른다.

감사 및 적대적 검토 결과, Write 추가(read-only reviewer 성격 훼손 + 직전 P1 Bash 협소화 방향과 상충)보다 본문 명확화가 권장된다.

구현

  • description: generates test skeletonsprovides test skeletons as report code blocks (no file writes). 위임 트리거 키워드(test skeleton/strategy)는 유지.
  • 본문 intro: generate test skeletons that follow existing project patternsprovide test skeletons (as report code blocks, not written to disk) that follow existing project patterns.
  • focus area: Generate test file scaffolding ...Provide test file scaffolding as report code blocks (no file writes) ....
  • process 단계: Generate recommendations and optional test skeletonsProvide recommendations and optional test skeletons as report code blocks.
  • tools 등 frontmatter는 변경하지 않음(Write/Edit 미추가).

검증

  • grep "as report code blocks" → 각 파일 4건(교체 1·2·3·4; 교체 2 문구가 substring 포함)
  • grep "^tools:"Read, Grep, Glob, Bash 유지
  • scripts/check_agents.shcheck_agents: OK (8 agent pairs in sync) (sandbox OFF 기준)

Closes #734
Part of #726

…file writes

test-strategist advertised generating test skeletons and scaffolding, but its read-only tool set (Read, Grep, Glob, Bash — no Write/Edit) cannot write files. Reword the description and three body mentions to state skeletons are provided as report code blocks (no file writes), matching the granted tools. tools and other frontmatter are unchanged.
@kcenon kcenon merged commit 5d728a3 into develop Jun 13, 2026
1 check passed
@kcenon kcenon deleted the fix/issue-734-test-strategist-skeleton-output branch June 13, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant