fix(agents): clarify test-strategist skeletons are report output not file writes#736
Merged
Merged
Conversation
…file writes test-strategist advertised generating test skeletons and scaffolding, but its read-only tool set (Read, Grep, Glob, Bash — no Write/Edit) cannot write files. Reword the description and three body mentions to state skeletons are provided as report code blocks (no file writes), matching the granted tools. tools and other frontmatter are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
test-strategist에이전트 정의(2개 파일)의 description과 본문 3곳을 수정하여, 테스트 스켈레톤이 디스크에 기록되는 파일이 아니라 report 코드블록으로 제시됨을 명확히 했다.배경
test-strategist는 description("generates test skeletons")과 본문("Generate test file scaffolding")에서 테스트 스켈레톤·scaffolding 생성을 핵심 기능으로 내세운다. 그러나tools는 read-only(Read, Grep, Glob, Bash—Write/Edit없음)라 실제로 파일을 디스크에 쓸 수 없다. 기능 약속과 부여된 권한이 어긋나, 사용자가 파일 생성을 기대하면 오해를 부른다.감사 및 적대적 검토 결과,
Write추가(read-only reviewer 성격 훼손 + 직전 P1Bash협소화 방향과 상충)보다 본문 명확화가 권장된다.구현
generates test skeletons→provides test skeletons as report code blocks (no file writes). 위임 트리거 키워드(test skeleton/strategy)는 유지.generate test skeletons that follow existing project patterns→provide test skeletons (as report code blocks, not written to disk) that follow existing project patterns.Generate test file scaffolding ...→Provide test file scaffolding as report code blocks (no file writes) ....Generate recommendations and optional test skeletons→Provide recommendations and optional test skeletons as report code blocks.tools등 frontmatter는 변경하지 않음(Write/Edit미추가).검증
grep "as report code blocks"→ 각 파일 4건(교체 1·2·3·4; 교체 2 문구가 substring 포함)grep "^tools:"→Read, Grep, Glob, Bash유지scripts/check_agents.sh→check_agents: OK (8 agent pairs in sync)(sandbox OFF 기준)Closes #734
Part of #726