fix(cmake): update install rules for migrated header paths#443
Merged
Conversation
After PR #440 migrated headers to include/kcenon/container/, two directories were missing from the cmake install rules: - include/container/ forwarding headers (for #include <container/...>) - messaging/ directory (message_container.h) This caused downstream build failures (e.g., network_system CI on Windows MSVC) when cmake --install did not copy these headers.
Contributor
Performance Benchmark ReportSummary
✅ Status: No significant performance regressions detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include/container/forwarding headers to cmake install rules (for#include <container/...>paths)messaging/directory to cmake install rules (message_container.h)Why
PR #440 migrated headers from
core/toinclude/kcenon/container/, but the cmake install rules were not fully updated. Whennetwork_systemCI runscmake --installoncontainer_system, the new forwarding headers underinclude/container/and themessaging/directory headers are not installed, causing downstream build failures on Windows MSVC (and potentially other platforms).Relates to network_system PRs #864, #865, #866 which fail on Windows due to this.
Where
CMakeLists.txt(install rules section, lines ~588-620)How
Changes
include/container/directory (forwarding headers that bridge#include <container/optimizations/fast_parser.h>to the canonicalinclude/kcenon/container/location)messaging/to the existing backward-compatible install rule (alongsidecore/,internal/,integration/)Verification
cmake --build buildcmake --install build --prefix /tmp/container_install_testinclude/kcenon/container/(canonical headers)include/container/optimizations/fast_parser.h(forwarding header, previously missing)include/messaging/message_container.h(previously missing)include/core/,include/internal/,include/integration/(unchanged)Test plan