Conversation
…ion,messaging}/ Move all 14 .cpp files from the four root-level feature directories into src/<subdir>/ to match the canonical kcenon ecosystem template. The four root-level directories (core/, internal/, integration/, messaging/) are removed by this commit. Source moves (preserving subdirectory structure): core/*.cpp -> src/core/*.cpp (4 files) core/serializers/*.cpp -> src/core/serializers/*.cpp (5 files) internal/*.cpp -> src/internal/*.cpp (3 files) integration/*.cpp -> src/integration/*.cpp (1 file) messaging/*.cpp -> src/messaging/*.cpp (1 file) Header includes are unchanged: every .cpp uses angle-bracket form <kcenon/container/...> resolved through target_include_directories, so source location is decoupled from include resolution. Drift fixes (minimal, scoped to keep the build green): - CMakeLists.txt: target source list paths updated to src/<subdir>/. - CMakeLists.txt: install(DIRECTORY core/ internal/ integration/ messaging/) block dropped because the directories no longer exist. The full install layout will be revisited in #536. - CMakeLists.txt: in-source DOXYGEN_INPUT block updated to use include/kcenon/container and src in place of the removed feature dirs. - Doxyfile: standalone INPUT directive updated the same way. - fuzz/CMakeLists.txt: removed dead ${CMAKE_SOURCE_DIR}/internal include path; internal headers are reachable via container_system's public include directory. Out of scope (handled by sibling sub-issues): forwarder deprecation (#534), CMake module decomposition (#535), full Doxyfile/install rewrite (#536). Closes #533 Part of #531
5 tasks
This was referenced May 1, 2026
kcenon
added a commit
that referenced
this pull request
May 1, 2026
Drop legacy layout references from Doxyfile, cmake/documentation.cmake, and cmake/install.cmake now that the post-EPIC-#531 directory layout is stable. - Doxyfile INCLUDE_PATH: replace removed roots (core/, values/, internal/, integration/) with the canonical include/, include/kcenon/ container/, and src/ paths. - Doxyfile INPUT: keep the canonical roots and explicit docs/*.dox pages; drop the temporary layout-disclaimer comment. - cmake/documentation.cmake DOXYGEN_INPUT: remove the source-root catch-all and the non-existent root mainpage.dox reference; add utilities/ and the explicit docs/*.dox pages so the CMake target and the standalone Doxyfile drive the same set of inputs. - cmake/install.cmake: rewrite the documentation block to reflect the actual install layout (canonical include/kcenon/container/ plus deprecated include/container/), record the v1.2.0 removal milestone for the legacy forwarding tree as a TODO marker, and drop the dropped- install-rule comment that was kept as a breadcrumb during #538/#535. - CHANGELOG.md and docs/CHANGELOG.md: record the cleanup under Unreleased > Changed. All INPUT paths verified to exist on disk. Toolchain unavailable in sandbox; relying on CI for cmake configure, build, and Doxygen target runs. Closes #536 Part of #531
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Move all 14
.cppsource files from the four root-level feature directories(
core/,internal/,integration/,messaging/) intosrc/<subdir>/, thenremove those four directories from the repository root. CMake target source
lists, the in-source
DOXYGEN_INPUTblock, the standaloneDoxyfileINPUTdirective, and the
fuzz/CMakeLists.txtinclude path are updated to match.Change Type
Affected Components
src/{core,internal,integration,messaging}/(new homes for 14 sources)CMakeLists.txt(target source paths + minimal install/Doxygen drift fix)Doxyfile(minimalINPUTdrift fix)fuzz/CMakeLists.txt(drop dead include path)Why
Problem Solved
After PR #537 consolidated headers under
include/kcenon/container/, the fourroot-level feature directories still held ~14
.cppfiles. Mixing sources atthe repo root blocks clean
install(...)layout and prevents the fourdirectories from being removed. Moving sources to
src/{core,internal,integration,messaging}/matches the canonical template used by sibling repositories in the EPIC.
Related Issues
Where
Source Moves
core/*.cppsrc/core/*.cppcore/serializers/*.cppsrc/core/serializers/*.cppinternal/*.cppsrc/internal/*.cppintegration/messaging_integration.cppsrc/integration/messaging_integration.cppmessaging/message_container.cppsrc/messaging/message_container.cppBuild Configuration
CMakeLists.txt: 14${CMAKE_CURRENT_SOURCE_DIR}/<dir>/*.cppreferences retargeted to${CMAKE_CURRENT_SOURCE_DIR}/src/<dir>/*.cppCMakeLists.txt: droppedinstall(DIRECTORY core/ internal/ integration/ messaging/ ...)block (those directories no longer exist; full install rewrite stays in scope of [#531-5/5] Update Doxygen input paths and install rules #536)CMakeLists.txt: in-sourceDOXYGEN_INPUTpaths updated to useinclude/kcenon/containerandsrcin place of the removed feature dirsDoxyfile: standaloneINPUTdirective updated the same wayfuzz/CMakeLists.txt: removed dead${CMAKE_SOURCE_DIR}/internalinclude from both fuzz targets (internal headers reach fuzz targets viacontainer_system's public include directory)How
Implementation
git mveach of the 14.cppfiles (preserves Git rename detection).core/,internal/,integration/,messaging/directories from the working tree.target_sourcespaths and minimal install/Doxygen drift fixes..cppalready uses the angle-bracket form<kcenon/container/...>resolved throughtarget_include_directories, so source location is decoupled from include resolution.Out of Scope (handled by sibling sub-issues)
[[deprecated]]to legacy forwarders ([#531-3/5] Mark legacy include/container/ forwarding [[deprecated]] #534)CMakeLists.txtintocmake/modules ([#531-4/5] Decompose CMakeLists.txt into cmake/ modules #535)Doxyfilerewrite or fullinstall(...)rule restructure ([#531-5/5] Update Doxygen input paths and install rules #536) — only the minimal drift fix needed to keep the build green is in this PRinclude/container/forwarding header ([#531-3/5] Mark legacy include/container/ forwarding [[deprecated]] #534)Testing
cmake/g++/clang++); relying on CI forcmake -S . -B build && cmake --build build/ -jandctest --output-on-failure.CMakeLists.txtandfuzz/CMakeLists.txt; no remaining references to root-levelcore/|internal/|integration/|messaging/paths.Breaking Changes
None at the public API or include level. Only internal target source lists and
documentation/install rules changed.
Acceptance Criteria
core/,internal/,integration/,messaging/no longer exist at repo rootsrc/<subdir>/cmake -S . -B build && cmake --build build/ -jsucceeds (CI)ctest --test-dir build/ --output-on-failurepasses (CI)