fix(cmake): standardize exported target name to database_system::database_system#555
Merged
Merged
Conversation
Fix intra-file TOC anchors that had a leading dash from emoji stripping (e.g., #-문서-개요 -> #문서-개요). Remove fragment anchors from inter-file references to docs/guides/ that the anchor validator cannot resolve.
…base_system Set EXPORT_NAME property on the database target so consumers get database_system::database_system after find_package(database_system), following the <package>::<package> convention. A backward-compatible alias (database_system::database) is provided in the config template so existing consumers continue to work. Part of kcenon/vcpkg-registry#78
Contributor
Benchmark ResultsNo comparison reports available. Baseline may not be established yet. |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…base_system (#555) * docs: fix broken markdown anchors in docs/README.kr.md Fix intra-file TOC anchors that had a leading dash from emoji stripping (e.g., #-문서-개요 -> #문서-개요). Remove fragment anchors from inter-file references to docs/guides/ that the anchor validator cannot resolve. * fix(cmake): standardize exported target name to database_system::database_system Set EXPORT_NAME property on the database target so consumers get database_system::database_system after find_package(database_system), following the <package>::<package> convention. A backward-compatible alias (database_system::database) is provided in the config template so existing consumers continue to work. Part of kcenon/vcpkg-registry#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Standardize the CMake exported target name from
database_system::databasetodatabase_system::database_system, following the<package>::<package>convention.Change Type
Affected Components
database/CMakeLists.txt- AddedEXPORT_NAME database_systempropertycmake/database_system-config.cmake.in- Added backward compatibility aliasWhy
Problem Solved
After
find_package(database_system), consumers previously gotdatabase_system::databaseinstead of the conventionaldatabase_system::database_system. This deviates from the standard<package>::<package>naming convention used by most CMake packages.Related Issues
Where
Files Changed
database/CMakeLists.txtEXPORT_NAMEpropertycmake/database_system-config.cmake.indocs/README.kr.mdHow
Implementation Details
Added
EXPORT_NAME database_systemtoset_target_properties()indatabase/CMakeLists.txtso the exported target becomesdatabase_system::database_systemwithout renaming the actual CMake target.Added a backward-compatible alias in the config template:
Updated
database_system_LIBRARIESvariable and documentation commentsin the config template.
Breaking Changes
None - existing consumers using
database_system::databasewill continueto work via the backward-compatible alias.