Skip to content

fix(security): replace FNV1a and XOR placeholders with real cryptography #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcenon merged 3 commits into from
Apr 13, 2026
Merged

fix(security): replace FNV1a and XOR placeholders with real cryptography #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afb2a85
fix(security): replace FNV1a and XOR placeholders with real cryptography
kcenon Apr 13, 2026
eaf659c
fix(security): use CMake-based OpenSSL detection instead of __has_inc…
kcenon Apr 13, 2026
bba4adb
fix(build): use BUILD_INTERFACE for OpenSSL link to fix export
kcenon Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ include(FindSystemDependency)
# Find required packages
find_package(Threads REQUIRED)

# Optional: OpenSSL for real cryptography in secure_connection
find_package(OpenSSL QUIET)
if(OPENSSL_FOUND)
message(STATUS "OpenSSL ${OPENSSL_VERSION} found — secure_connection will use PBKDF2/AES-256-GCM")
else()
message(STATUS "OpenSSL not found — secure_connection will use placeholder crypto (NOT for production)")
endif()

##################################################
# ASIO dependency (required, header-only)
#
Expand Down
7 changes: 7 additions & 0 deletions database/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ target_include_directories(${PROJECT_NAME} PUBLIC
find_package(Threads REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC Threads::Threads)

# OpenSSL for real cryptography in secure_connection (optional)
# Use BUILD_INTERFACE to avoid requiring consumers to find_package(OpenSSL)
if(OPENSSL_FOUND)
target_compile_definitions(${PROJECT_NAME} PRIVATE DATABASE_HAS_OPENSSL)
target_link_libraries(${PROJECT_NAME} PRIVATE $<BUILD_INTERFACE:OpenSSL::Crypto>)
endif()

# thread_system integration (optional)
if(USE_THREAD_SYSTEM)
set(_DATABASE_THREAD_HANDLED FALSE)
Expand Down
Loading
Loading