fix(security): mark no_tls policy as deprecated#877
Merged
Conversation
Mark no_tls with [[deprecated]] attribute to guide users toward require_tls or optional_tls for production deployments.
kcenon
added
bug
Contributor
Coverage Report
Coverage DetailsFull HTML report is available as a build artifact. |
Contributor
Performance ComparisonBase Branch ResultsNo base results PR Branch ResultsNo PR results |
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
Mark no_tls with [[deprecated]] attribute to guide users toward require_tls or optional_tls for production deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
[[deprecated]]attribute to theno_tlsstruct to emit compiler warnings when used, guiding users toward TLS-enabled policies for production deployments.Why
Fixes #871 -- Using
no_tlsin production is a security risk. While the struct must remain available for testing and development, a deprecation warning makes the security implication visible at compile time.How
tls_policy.h: Added[[deprecated("Use require_tls or optional_tls for production deployments")]]to theno_tlsstruct declarationBreaking Changes
None -- Existing code compiles and functions identically. Users will see deprecation warnings which can be suppressed if intentional (e.g., test code).