Skip to content

chore(tests): move integration_tests under tests/integration_tests#689

Merged
kcenon merged 1 commit intodevelopfrom
chore/issue-686-integration-tests-reorg
May 2, 2026
Merged

chore(tests): move integration_tests under tests/integration_tests#689
kcenon merged 1 commit intodevelopfrom
chore/issue-686-integration-tests-reorg

Conversation

@kcenon
Copy link
Copy Markdown
Owner

@kcenon kcenon commented May 2, 2026

Closes #686

Part of #683.

Summary

Move integration_tests/ to tests/integration_tests/ so the test layout matches the ecosystem-wide tests/{unit,stress,integration_tests,benchmarks}/ standard. Update tests/CMakeLists.txt to add the subdirectory under the existing THREAD_BUILD_INTEGRATION_TESTS gate, and remove the legacy top-level branch from add_tests_subdirectory() in cmake/thread_system_targets.cmake.

Changes

  • git mv integration_tests tests/integration_tests (25 files relocated)
  • tests/CMakeLists.txt: add gated add_subdirectory(integration_tests) block; document layout in header comment.
  • cmake/thread_system_targets.cmake: remove the now-dead top-level integration_tests branch from add_tests_subdirectory().
  • scripts/run_valgrind.sh: update the binary path from build/integration_tests/ to build/tests/integration_tests/ since CMake places executables in their source-relative directory.
  • .github/workflows/integration-tests.yml: update two hashFiles() cache keys to point at the new CMakeLists.txt path.
  • docs/TRACEABILITY.md, docs/guides/COVERAGE_GUIDE.md: refresh active path references.

Test Plan

  • cmake -DTHREAD_BUILD_INTEGRATION_TESTS=ON --preset debug should configure cleanly
  • cmake --build --preset debug should build integration_tests / smoke_tests / performance_tests
  • ctest --test-dir build-debug -R integration should pass

Local toolchain (cmake, g++) is unavailable in this sandbox, so build verification was done by static inspection only (control-flow tokens balance, referenced include directories exist, no orphan paths). Full build verification will run on the eventual main-targeted release PR per ci-resilience policy.

Out of Scope

Verification of Source File Includes

Source files under tests/integration_tests/{smoke,integration,scenarios,performance}/ use #include "../framework/...". These are relative to the source file's own directory and remain correct after the move because framework/ is still a sibling. CMake CMAKE_SOURCE_DIR references in the moved CMakeLists.txt continue to resolve to the repo root and were left unchanged.

Relocate the top-level integration_tests/ directory to
tests/integration_tests/ to match the ecosystem-wide
tests/{unit,stress,integration_tests,benchmarks} layout.

Update tests/CMakeLists.txt to add the subdirectory under
the existing THREAD_BUILD_INTEGRATION_TESTS gate, and remove
the legacy top-level branch from add_tests_subdirectory() in
cmake/thread_system_targets.cmake.

Repoint the build-output reference in scripts/run_valgrind.sh
from build/integration_tests/ to build/tests/integration_tests/,
and update the hashFiles cache keys in
.github/workflows/integration-tests.yml to track the new
CMakeLists.txt path. Refresh active path mentions in
docs/TRACEABILITY.md and docs/guides/COVERAGE_GUIDE.md.

Part of #683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant