Skip to content

feat: support login with password from stdin #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Apr 23, 2025

fixes #223

since this is using the feature from kpm, so i think it's not need tests here.

verified:

$ bin/kcl registry login ghcr.io -uliangyuanpeng --password-stdin
Password: 
Login Succeeded
$ mkdir tmp
$ sudo mv bin/kcl /usr/local/bin/kcl
$ cd tmp/
$ kcl mod init
creating new :/workspace/kcl-cli/tmp/kcl.mod
creating new :/workspace/kcl-cli/tmp/kcl.mod.lock
creating new :/workspace/kcl-cli/tmp/main.k
package 'tmp' init finished
$ kcl mod push oci://ghcr.io/liangyuanpeng/kcl-cli:hello
package 'tmp' will be pushed
pushed [registry] ghcr.io/liangyuanpeng/kcl-cli:hello
digest: sha256:e2111d9914e252102984cb4947543cf6e895ae72840c709c92242140119de152

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14611294046

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.542%

Totals Coverage Status
Change from base Build 14597908774: 0.0%
Covered Lines: 99
Relevant Lines: 637

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Apr 24, 2025

LGTM. Thank you!

@Peefy Peefy merged commit b879bed into kcl-lang:main Apr 24, 2025
12 checks passed
@liangyuanpeng liangyuanpeng deleted the login_stdin branch April 24, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS ECR login for pushing OCI images
3 participants