Skip to content

fix: correct IP address type tests #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

johngmyers
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixes #1924

2. What is the scope of this PR (e.g. component or file name):

kclvm/runtine/src/net

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Fixes various errors in the net system module:

  • IPv4 has no interface-local multicast IPs
  • IPv6 has more interface-local and link-local IP blocks
  • The test for IPv6 global unicast was completely wrong

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

N

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: John Gardiner Myers <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14539350311

Details

  • 0 of 31 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 70.568%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/net/mod.rs 0 31 0.0%
Totals Coverage Status
Change from base Build 14532923202: -0.01%
Covered Lines: 53704
Relevant Lines: 76103

💛 - Coveralls

@zong-zhe
Copy link
Contributor

Hello @johngmyers 😄

Can you add a test case for your PR? You can refer to here
https://github.com/kcl-lang/kcl/tree/main/kclvm/tests/test_units/runtime to implement this test case.

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need ut

@Peefy Peefy merged commit dbac5c1 into kcl-lang:main Apr 24, 2025
13 checks passed
@liangyuanpeng liangyuanpeng mentioned this pull request Apr 28, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various errors in net module address-type tests
5 participants