replace setup-envtest with µget #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
kcp-ci-bot
added
the
size/M
Contributor
Author
|
/retest |
On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
no-more-envtest
branch
from
94e7b21 to
b3f1538
Compare
Contributor
Author
|
/approve |
kcp-ci-bot
added
the
approved
Contributor
|
LGTM label has been added. Git tree hash: e1e99dc359e60e4a6b289f70e1ee17219fb5c511
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setup-envtesthas two drawbacks:Both problems can easily by solved by just using µget, which will keep the files deletable, has its own checksumming mechanism, reduces dependence on GitHub and, using
UGET_CACHE, can have a system-wide cache so amake clean-tools test-e2edoes not have to download anything at all.What Type of PR Is This?
/kind cleanup
Release Notes