Skip to content

🌱 Remove emojis from PR template and verification #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

embik
Copy link
Member

@embik embik commented Apr 8, 2025

Summary

To make sure our PR experience is consistent across the projects, this also updates the api-syncagent PR template to not use emojis anymore but instead provide a selection of /kind commands.

/kind cleanup

Related issue(s)

Towards kcp-dev/kcp#3351

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2025
@embik embik requested a review from xrstf April 8, 2025 09:07
@xrstf
Copy link
Contributor

xrstf commented Apr 8, 2025

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 037440c5761cfb7432c3638016e216299c1d4177

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@kcp-ci-bot kcp-ci-bot merged commit 31f565a into kcp-dev:main Apr 8, 2025
13 checks passed
@embik embik deleted the remove-emoji-prs branch April 8, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants