-
Notifications
You must be signed in to change notification settings - Fork 7
Handle API lifecycle #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…esource On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
…VK anymore) On-behalf-of: @SAP [email protected]
…on logic accessibility On-behalf-of: @SAP [email protected]
…n reconciling APIExports On-behalf-of: @SAP [email protected]
…local/remote GVKs On-behalf-of: @SAP [email protected]
…ometimes?) On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
Since a CRD has a _list_ of versions, there is no risk of running into map collisions when renaming versions, so we can slim down our API to just a map, no individual steps. On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
…ier, adjust it to the new logic On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
/kind feature |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 43dd2caa99d5854f9e30eeb8c48a6dcd462f2d0c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR extends the Agent's support for handling the lifecycle of CRDs. Notably, updates to CRDs are now reflected in kcp.
This PR started as #61, but then I noticed that even though APIConversions are a documented feature of kcp, they have in fact been entirely removed from kcp 2 years ago, except for their API types. So I forked #61 and trimmed it down to everything else.
This means even though the agent can now handle CRD updates and even multiple versions, there is absolutely no support whatsoever for conversions.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #12
Release Notes