Skip to content

Handle API lifecycle #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Handle API lifecycle #62

wants to merge 26 commits into from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 21, 2025

Summary

This PR extends the Agent's support for handling the lifecycle of CRDs. Notably, updates to CRDs are now reflected in kcp.

This PR started as #61, but then I noticed that even though APIConversions are a documented feature of kcp, they have in fact been entirely removed from kcp 2 years ago, except for their API types. So I forked #61 and trimmed it down to everything else.

This means even though the agent can now handle CRD updates and even multiple versions, there is absolutely no support whatsoever for conversions.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #12

Release Notes

* handle CRD updates (create new APIResourceSchemas, update APIExports)
* allow to select and publish more than one version of each CRD

xrstf added 24 commits May 16, 2025 16:33
Since a CRD has a _list_ of versions, there is no risk of running into map collisions when renaming
versions, so we can slim down our API to just a map, no individual steps.

On-behalf-of: @SAP [email protected]
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2025
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 21, 2025
@embik
Copy link
Member

embik commented May 21, 2025

/kind feature

@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 21, 2025
@xrstf
Copy link
Contributor Author

xrstf commented May 21, 2025

/retest

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43dd2caa99d5854f9e30eeb8c48a6dcd462f2d0c

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: actively manage lifecycle of resource schemas
3 participants