Skip to content

update golangci-lint to 2.1.6 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update golangci-lint to 2.1.6 #64

wants to merge 2 commits into from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 21, 2025

Summary

One of the less painful golangci-lint 2 migrations I have seen and done in the last few weeks.

What Type of PR Is This?

/kind chore

Release Notes

NONE

@xrstf xrstf requested a review from embik May 21, 2025 15:41
@kcp-ci-bot
Copy link
Contributor

@xrstf: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

Summary

One of the less painful golangci-lint 2 migrations I have seen and done in the last few weeks.

What Type of PR Is This?

/kind chore

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 21, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrstf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2025
@xrstf
Copy link
Contributor Author

xrstf commented May 21, 2025

/kind cleanup

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik Awaiting requested review from embik

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrstf @kcp-ci-bot