-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for Go template expressions in PublishedResources #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
/retest |
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor nits/questions. Overall awesome PR.
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
Summary
This PR completes what we begun in #44: it adds support for Go templates in various places in a PublishedResource.
Please see the attached updated documentation for more information on how templating works.
In the old agent default, we used variables like
$remoteNamespaceHash
to construct object names. However these hashes were very limited:I saw this PR as a good opportunity to clean this up. So I changed the defaults to using SHA-3 instead, because I made it possible for users to keep their old naming rules by using the
shortHash
function in the agent.So if you didn't configure any naming rules before, you will now need to either accept that objects will be placed in new locations (because the hashes will change) or you need to explicitly configure naming rules using the
shortHash
function to mimic the old default.This PR also contains a clarification: In #44 we said
This was however not true from the code. This PR adjusts the code to actually make seemingly-broken references work as documented.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #46
Release Notes