-
Notifications
You must be signed in to change notification settings - Fork 29
Add the ability to provide imagePullSecrets for private Registries or Registries with auth #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add the ability to provide imagePullSecrets for private Registries or Registries with auth #141
Conversation
Signed-off-by: Cyrill Berg <[email protected]>
Signed-off-by: Cyrill Berg <[email protected]>
Signed-off-by: Cyrill Berg <[email protected]>
… removed Signed-off-by: Cyrill Berg <[email protected]>
… removed Signed-off-by: Cyrill Berg <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @BergCyrill. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
When trying to use the provided helm charts in an air-gapped environment (or) with a private registry using authentication it will fail. This PR adds the ability to optionally provide imagePullSecrets for every chart.
Tested it on a local kind cluster and validated the Deployment manifests with and without providing imagePullSecrets.