Skip to content

Update to Go 1.24.8 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
embik wants to merge 8 commits into from
+15 −15
Closed

Update to Go 1.24.8 #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c6bcbc
Update to Go 1.24.8
embik Oct 8, 2025
fc55c51
Use new build image with updated docker and kind
embik Oct 9, 2025
280cfce
Use latest kind node image
embik Oct 10, 2025
39edf06
Build both images
embik Oct 10, 2025
889da78
More testing
embik Oct 10, 2025
ffedb10
Further downgrade
embik Oct 10, 2025
47a8751
Update again
embik Oct 10, 2025
b3cee29
Try newest kind/node image
embik Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docs-gen-and-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ jobs:

- uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # tag=v5.4.0
with:
go-version: v1.24.3
go-version: v1.24.8
cache: true

- uses: actions/setup-python@8d9ed9ac5c53483de85588cdf95a591a75ab9f55 #tag=v5.5.0
with:
python-version: '3.10'
cache: 'pip'
python-version: "3.10"
cache: "pip"

# mike does not support giving CLI flags for mkdocs, but we also do not
# want to permanently enable strict mode, so here we enable it just for this
Expand Down
14 changes: 7 additions & 7 deletions .prow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.24.4-1
- image: ghcr.io/kcp-dev/infra/build:1.24.8-2
command:
- make
- verify
Expand All @@ -24,7 +24,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.24.4-1
- image: ghcr.io/kcp-dev/infra/build:1.24.8-2
command:
- make
- lint
Expand All @@ -47,7 +47,7 @@ presubmits:
- hack/ci/build-image.sh
env:
- name: DRY_RUN
value: '1'
value: "1"
# docker-in-docker needs privileged mode
securityContext:
privileged: true
Expand All @@ -65,13 +65,13 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.24.4-1
- image: ghcr.io/kcp-dev/infra/build:1.24.8-2
command:
- make
- test
env:
- name: USE_GOTESTSUM
value: '1'
value: "1"
resources:
requests:
memory: 4Gi
Expand All @@ -86,7 +86,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.24.4-1
- image: ghcr.io/kcp-dev/infra/build:1.24.8-2
command:
- hack/ci/run-e2e-tests.sh
resources:
Expand All @@ -106,7 +106,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.24.4-1
- image: ghcr.io/kcp-dev/infra/build:1.24.8-2
command:
- hack/ci/run-e2e-tests.sh
env:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM --platform=${BUILDPLATFORM} docker.io/golang:1.24.4 AS builder
FROM --platform=${BUILDPLATFORM} docker.io/golang:1.24.8 AS builder
ARG TARGETOS
ARG TARGETARCH

Expand Down
8 changes: 4 additions & 4 deletions hack/ci/run-e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,20 @@ fi
export IMAGE_TAG=local

echo "Building container images..."
ARCHITECTURES=arm64 DRY_RUN=yes ./hack/ci/build-image.sh
ARCHITECTURES="arm64" DRY_RUN=yes ./hack/ci/build-image.sh

# start docker so we can run kind
start-docker.sh

# create a local kind cluster
KIND_CLUSTER_NAME=e2e

echo "Preloading the kindest/node image..."
docker load --input /kindest.tar
#echo "Preloading the kindest/node image..."
#docker load --input /kindest.tar

export KUBECONFIG=$(mktemp)
echo "Creating kind cluster $KIND_CLUSTER_NAME..."
kind create cluster --name "$KIND_CLUSTER_NAME"
kind create cluster --name "$KIND_CLUSTER_NAME" --image kindest/node:v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a
chmod 600 "$KUBECONFIG"

# store logs as artifacts
Expand Down