add ability to reference OIDC client secret from secret object #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olalekan odukoya <[email protected]>
kcp-ci-bot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/L
mjudeikis
reviewed
Jan 5, 2026
Contributor
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
This is just api? no implementation yet?
| Name string `json:"name"` | ||
| // Namespace is the namespace of the secret. If not specified, the secret is assumed to be in the same namespace as the resource. | ||
| // +optional | ||
| Namespace string `json:"namespace,omitempty"` |
Contributor
There was a problem hiding this comment.
Is there point having namespace here? Can we refer and use secrets cross-namespaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
/kind api-change
Related Issue(s)
Fixes 130
Release Notes