Skip to content

🌱 stop the bleeding: e2e/sharded: temporarily disable service account lookup #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

sttts
Copy link
Member

@sttts sttts commented Jan 26, 2025

Summary

The real fix might be #3274. But to reduce flakes, we need this quick fix in e2e.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2025
@sttts sttts force-pushed the sttts-sa-lookup-stop-the-bleeding branch from 774f75c to e5b9ad7 Compare January 26, 2025 22:34
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87768d999520ec62765a6e28451fd56818d1c01e

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@sttts
Copy link
Member Author

sttts commented Jan 27, 2025

/retest

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@kcp-ci-bot kcp-ci-bot requested a review from mjudeikis January 27, 2025 09:32
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed40b5c1cef65e230d597003dff998ff6ca1939a

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjudeikis
Copy link
Contributor

/retest
? still flakes :/

@mjudeikis
Copy link
Contributor

/retest

@kcp-ci-bot kcp-ci-bot merged commit 4c2d106 into kcp-dev:main Jan 31, 2025
16 checks passed
@embik embik added this to the v0.27.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants