Skip to content

[release-0.27] 🐛 Do not set up local mini-front-proxy without additional mappings file #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcp-ci-bot merged 1 commit into from
Apr 8, 2025
Merged

[release-0.27] 🐛 Do not set up local mini-front-proxy without additional mappings file #3362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/server/localproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,11 @@ func WithLocalProxy(
handler.ServeHTTP(w, req.WithContext(ctx))
})

// if no additional mappings are provided, do not start local-only mini-front-proxy.
if additionalMappingsFile == "" {
return defaultHandlerFunc, nil
}

// If additional mappings file is provided, read it and add the mappings to the handler
handlers, err := NewLocalProxyHandler(defaultHandlerFunc, indexState, additionalMappingsFile)
if err != nil {
Expand Down