update golangci-lint to v2 #3391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
do-not-merge/needs-kind
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
removed
do-not-merge/needs-kind
cnvergence
force-pushed
the
update-golangci-lint
branch
from
9dd832c to
70123cc
Compare
kcp-ci-bot
added
area/cli
cnvergence
force-pushed
the
update-golangci-lint
branch
from
70123cc to
b839021
Compare
|
/honk |
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
|
/hold |
kcp-ci-bot
added
the
do-not-merge/hold
|
Putting it on hold, disabled WARN [runner] Can't run linter goanalysis_metalinter: gci: error while running gci: 27:59: expected ';', found "github.com/kcp-dev/logicalcluster/v3" (and 2 more errors)
ERRO Running error: can't run linter goanalysis_metalinter
gci: error while running gci: 27:59: expected ';', found "github.com/kcp-dev/logicalcluster/v3" (and 2 more errors)
make: *** [imports] Error 3 |
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
cnvergence
force-pushed
the
update-golangci-lint
branch
from
b839021 to
98ae1aa
Compare
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
cnvergence
force-pushed
the
update-golangci-lint
branch
from
9e11f96 to
b97046f
Compare
|
cc @xrstf |
|
/honk |
|
xref daixiang0/gci#232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update golangci-lint to v2, migrate the old configuration and fix all the lint issues.
What Type of PR Is This?
/kind chore
Related Issue(s)
Fixes #3378
Release Notes