Skip to content

update to Go 1.23.10 #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcp-ci-bot merged 1 commit into from
Jun 6, 2025
Merged

update to Go 1.23.10 #3443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs-gen-and-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # tag=v5.5.0
with:
go-version: v1.23.7
go-version: v1.23.10
cache: true

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 #tag=v5.6.0
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # tag=v4.2.2
with:
fetch-depth: 0

- uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # tag=v5.5.0
with:
go-version: v1.23.7
go-version: v1.23.10

- name: Delete non-semver tags
run: 'git tag -d $(git tag -l | grep -v "^v")'

- name: Set LDFLAGS
run: echo LDFLAGS="$(make ldflags)" >> $GITHUB_ENV

- name: Run GoReleaser on tag
if: github.event_name != 'pull_request'
uses: goreleaser/goreleaser-action@9c156ee8a17a598857849441385a2041ef570552 # tag=v6.3.0
Expand All @@ -37,6 +41,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
KREW_GITHUB_TOKEN: ${{ secrets.KREW_GITHUB_TOKEN }}

- name: Run GoReleaser on pull request
if: github.event_name == 'pull_request'
uses: goreleaser/goreleaser-action@9c156ee8a17a598857849441385a2041ef570552 # tag=v6.3.0
Expand All @@ -47,6 +52,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
KREW_GITHUB_TOKEN: ${{ secrets.KREW_GITHUB_TOKEN }}

- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # tag=v4.6.2
if: ${{ always() }}
with:
Expand Down
18 changes: 9 additions & 9 deletions .prow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- make
- verify-boilerplate
Expand All @@ -27,7 +27,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- make
- verify-codegen
Expand All @@ -44,7 +44,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- make
- lint
Expand Down Expand Up @@ -83,7 +83,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- make
- test
Expand All @@ -104,7 +104,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- ./hack/run-with-prow.sh
- ./hack/run-with-prometheus.sh
Expand All @@ -131,7 +131,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- ./hack/run-with-prow.sh
- ./hack/run-with-prometheus.sh
Expand Down Expand Up @@ -160,7 +160,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- ./hack/run-with-prow.sh
- ./hack/run-with-prometheus.sh
Expand Down Expand Up @@ -191,7 +191,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- ./hack/run-with-prow.sh
- ./hack/run-with-prometheus.sh
Expand Down Expand Up @@ -220,7 +220,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.23.7-2
- image: ghcr.io/kcp-dev/infra/build:1.23.10-1
command:
- ./hack/run-with-prow.sh
- ./hack/run-with-prometheus.sh
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.

# Build the binary
FROM --platform=${BUILDPLATFORM} docker.io/golang:1.23.7 AS builder
FROM --platform=${BUILDPLATFORM} docker.io/golang:1.23.10 AS builder
WORKDIR /workspace

# Install dependencies.
Expand Down
2 changes: 1 addition & 1 deletion docs/content/contributing/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ contribution. See the [DCO](https://github.com/kcp-dev/kcp/tree/main/DCO) file f
### Prerequisites

1. Clone this repository.
2. [Install Go](https://golang.org/doc/install) (currently 1.23.7).
2. [Install Go](https://golang.org/doc/install) (currently 1.23.10).
3. Install [kubectl](https://kubernetes.io/docs/tasks/tools/#kubectl).

Please note that the go language version numbers in these files must exactly agree: go/go.mod file, kcp/.ci-operator.yaml, kcp/Dockerfile, and in all the kcp/.github/workflows yaml files that specify go-version. In kcp/.ci-operator.yaml the go version is indicated by the "tag" attribute. In kcp/Dockerfile it is indicated by the "golang" attribute. In go.mod it is indicated by the "go" directive." In the .github/workflows yaml files it is indicated by "go-version"
Expand Down
Loading