Skip to content

Conversation

@embik
Copy link
Member

@embik embik commented Oct 16, 2025

Summary

We updated to Go 1.24.8 in #3634, but that Go version has a known issue with parsing X509 certificates which caused some K8s upstream issues. Let's bump kcp as well to ensure we don't release a faulty build.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Towards kcp-dev/infra#136

Release Notes

kcp is built with Go 1.24.9

On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@embik embik requested a review from mjudeikis October 16, 2025 09:57
@embik
Copy link
Member Author

embik commented Oct 16, 2025

/cherry-pick release-0.28

@kcp-ci-bot
Copy link
Contributor

@embik: once the present PR merges, I will cherry-pick it on top of release-0.28 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc09fd8f50f5cf630857c547e6d18cd18ca35c61

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@mjudeikis
Copy link
Contributor

/retest

@kcp-ci-bot kcp-ci-bot merged commit cfaad25 into kcp-dev:main Oct 17, 2025
15 checks passed
@kcp-ci-bot
Copy link
Contributor

@embik: #3651 failed to apply on top of branch "release-0.28":

Applying: Update to Go 1.24.9
Using index info to reconstruct a base tree...
M	.github/workflows/docs-gen-and-push.yaml
M	.github/workflows/goreleaser.yml
M	.prow.yaml
M	Dockerfile
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging Dockerfile
CONFLICT (content): Merge conflict in Dockerfile
Auto-merging .prow.yaml
CONFLICT (content): Merge conflict in .prow.yaml
Auto-merging .github/workflows/goreleaser.yml
CONFLICT (content): Merge conflict in .github/workflows/goreleaser.yml
Auto-merging .github/workflows/docs-gen-and-push.yaml
CONFLICT (content): Merge conflict in .github/workflows/docs-gen-and-push.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update to Go 1.24.9
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants