Skip to content

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 4, 2025

Summary

This PR moves the CLI from github.com/kcp-dev/kcp/cli into github.com/kcp-dev/cli. The sdk repository has been already initialized: https://github.com/kcp-dev/cli

CLI is now a staged repository, similar to apimachinery, client-go, code-generator, and sdk. The source code is maintained in staging/src/github.com/kcp-dev/cli in the main kcp repo.

The reason for doing this is the same as for #3694.

This has been discussed in https://kubernetes.slack.com/archives/C09C7UP1VLM/p1761653814066419

What Type of PR Is This?

/kind api-change
(import path is changed)

/kind cleanup

Related Issue(s)

xref #3640 #3375

Release Notes

[ACTION REQUIRED] The kcp CLI has been moved from `github.com/kcp-dev/kcp/cli` to `github.com/kcp-dev/cli`. The source code is maintained in `staging/src/github.com/kcp-dev/cli` in the main kcp repo (i.e. `cli` is a staged repository). This does not effect the existing `cli` releases. The CLI users will be required to change the import paths in their Go code and `go.mod` upon upgrading the CLI.

/assign @xrstf

@kcp-ci-bot kcp-ci-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Nov 4, 2025

/test pull-kcp-test-e2e-sharded

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Nov 4, 2025

/test pull-kcp-test-e2e-sharded

@xrstf
Copy link
Contributor

xrstf commented Nov 4, 2025

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 067deb29ac49c0c2d294093ffd4ca02e45aa2c04

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Nov 4, 2025

/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@kcp-ci-bot kcp-ci-bot merged commit ed4d296 into kcp-dev:main Nov 4, 2025
15 checks passed
@xmudrii xmudrii deleted the stage-cli branch November 4, 2025 16:56
@xmudrii xmudrii removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants