Production deployment documentation #3712
Conversation
kcp-ci-bot
added
kind/documentation
| garbageCollectionPolicy: Exponential | ||
| garbageCollectionPeriod: 43200s | ||
| deltaSnapshotPeriod: 300s | ||
| deltaSnapshotMemoryLimit: 1Gi |
There was a problem hiding this comment.
Not much important because this is about backups, but maybe it would be useful to have a comment why are these values chosen (e.g. if they're default, changed because it's better in prod this way, etc).
There was a problem hiding this comment.
This was taken from etcd-druid docs. would be good if they could comment on this. Never teted this myself :/
| - "*.alpha-peer.kcp-comer.svc" | ||
| - "*.alpha-peer.kcp-comer.svc.cluster.local" | ||
| issuerRef: | ||
| name: etcd-ca |
There was a problem hiding this comment.
Why is this not using etcd-ca from the kcp-comer namespace, similar to etcd-tls-ca?
There was a problem hiding this comment.
Might be miskate. Need to test before I change it. TBH re-testing this means rebuilding everything. So will take a note and once I do next rebuild - will check.
There was a problem hiding this comment.
Will leave it for now, and will creat follow-up issue to test this again.
There was a problem hiding this comment.
Does it make sense that we put comments such as # CHANGE ME for fields that should be changed (e.g. dnsNames)? That way, people can easier find it, and we can say in docs search for CHANGE ME and change those values.
There was a problem hiding this comment.
Change me confuses too. When you see #Change me. Its not always clear what it should be? Root url, shard url, workspace URL?
All this should be used as a reference, not "as is". So having real values gives more context that changes me and explanations. In general, this is a start, and once we get feedback, we can iterate.
mjudeikis
force-pushed
the
mjudeikis/production.readiness
branch
from
269d3b4 to
c2befd5
Compare
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: @SAP [email protected]
mjudeikis
force-pushed
the
mjudeikis/production.readiness
branch
from
c2befd5 to
8311dd9
Compare
xmudrii
left a comment
xmudrii
left a comment
There was a problem hiding this comment.
Some final nits as of now. I would say, after these are fixed, we merge this PR and iterate as needed.
|
/retest |
|
LGTM label has been added. Git tree hash: b35fbfda6c02a9e7796646dddc53602f0bb18c4c
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
4 participants
Summary
This PR adds detailed deployment documentation on how to deploy kcp in a production configuration.
/kind documentation
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes