Skip to content

Conversation

@olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Nov 24, 2025

Summary

change fixes bug that prevents the deletion of a cachedresource that makes a
reference to a resource that doesn't have gvr
image

What Type of PR Is This?

Related Issue(s)

Fixes 3729

Release Notes

Fixed a bug that prevents the deletion of a cachedresource that makes a
reference to a resource that doesn't have GVR.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2025
@olamilekan000
Copy link
Contributor Author

/retest

1 similar comment
@olamilekan000
Copy link
Contributor Author

/retest

@olamilekan000 olamilekan000 force-pushed the fix-bug-when-deleting-cachedresource-with-no-existing-reosurce branch from 1e0f1f5 to f5fc00a Compare November 25, 2025 12:10
@kcp-ci-bot kcp-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2025
@olamilekan000 olamilekan000 requested a review from gman0 November 25, 2025 12:16
@olamilekan000
Copy link
Contributor Author

/retest

2 similar comments
@gman0
Copy link
Contributor

gman0 commented Nov 25, 2025

/retest

@olamilekan000
Copy link
Contributor Author

/retest

@gman0
Copy link
Contributor

gman0 commented Nov 25, 2025

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27f74aa799ce42b120ba17af23d825d80990de8c

@olamilekan000 olamilekan000 changed the title fix bug when trying to delete a cache resource fix bug when trying to delete a cached resource Nov 25, 2025
Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@gman0
Copy link
Contributor

gman0 commented Nov 25, 2025

/kind bug

@kcp-ci-bot kcp-ci-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 25, 2025
@kcp-ci-bot kcp-ci-bot merged commit 84b6f5b into kcp-dev:main Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: CachedResource fails to delete when resource does not exists or isn't valid

4 participants