fix: #761, don't store mails - store their IDs#896
Draft
isosphere wants to merge 4 commits into
Draft
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Owner
|
Thanks @isosphere for trying to tackle this issue!
I'm OK with this approach. In fact I am OK with any approach as long as all unittests are passing! 😅 If you manage to find a way to shave off some memory consumption, I'll be happy to merge your PR and cut a release. |
Owner
|
It's been a long time since I dived into the core of that project, so I trust you to make sensible choices, and will not be too much nitpicky about the code. But I'll make the effort of properly releasing it once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP. Successfully hashes all mails and executes actions with < 200 MB of RAM for 107k emails.
Requires a bit more testing to ensure I didn't mess anything up. I've run it on my own mail archives.
Solves out of memory condition by not storing mail instances in memory.
This PR fixes #761.
Previously we would require 570 kB - 1.8 MB per email in memory to complete execution. This was primarily due to this line:
mail-deduplicate/mail_deduplicate/deduplicate.py
Line 424 in 43da1f2
... which kept the
mailreference alive outside of the inner loop ofiteritems, which kept the object in memory. I solved this by storing a reference to the mail box + mail id instead, and fetching those later as needed.Preliminary checks
New Features Submissions:
Changes to Core Features: