Fix missing tolerations keyword#862
Merged
Merged
Conversation
Signed-off-by: Mikolaj Mackowiak <7921224+miqm@users.noreply.github.com>
miqm
force-pushed
the
fix/missing-tolerations
branch
from
d399579 to
7c9d5c1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Helm chart rendering failures when global .Values.tolerations is set but component-specific tolerations are not, by ensuring the tolerations: key is emitted in the fallback path (Fixes #861).
Changes:
- Add missing
tolerations:key when falling back to global.Values.tolerationsin webhooks deployment template. - Add missing
tolerations:key when falling back to global.Values.tolerationsin metrics-server deployment template. - Add missing
tolerations:key when falling back to global.Values.tolerationsin manager/operator deployment template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| keda/templates/webhooks/deployment.yaml | Ensures tolerations: is rendered for global tolerations fallback. |
| keda/templates/metrics-server/deployment.yaml | Ensures tolerations: is rendered for global tolerations fallback. |
| keda/templates/manager/deployment.yaml | Ensures tolerations: is rendered for global tolerations fallback (but still needs indentation fix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
approved these changes
Jun 2, 2026
kedifybot
added a commit
to kedify/charts
that referenced
this pull request
Jun 2, 2026
Backport of kedacore#862 into the published v2.20.0-1 chart so the global .Values.tolerations fallback renders the tolerations: key in the operator, metrics-server and webhooks deployments. Chart version unchanged (v2.20.0-1); tarball intentionally diverges from the matching git tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wozniakjan
added a commit
to kedify/charts
that referenced
this pull request
Jun 2, 2026
Fix missing tolerations keyword (kedacore#862) * Fix missing tolerations keyword * Potential fix for pull request finding --------- (cherry picked from commit 102f5f2) Signed-off-by: Mikolaj Mackowiak <7921224+miqm@users.noreply.github.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Mikolaj Mackowiak <7921224+miqm@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
10 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #861