Skip to content

Conversation

@julianguinard
Copy link
Contributor

@julianguinard julianguinard commented Feb 24, 2025

this related to the addition of aggregateFromKubeServiceEndpoints and aggregationType parameters in PR 6565, used to fetch/aggregate metrics from a kubernetes service's list of endpoints

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@julianguinard julianguinard requested a review from a team as a code owner February 24, 2025 16:46
@julianguinard julianguinard marked this pull request as draft February 24, 2025 16:46
@netlify
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 26650dd
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/68adaed740bbdb0008f82440
😎 Deploy Preview https://deploy-preview-1541--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@julianguinard julianguinard force-pushed the add-metrics-api-aggregation-from-kube-service-feature branch 3 times, most recently from a90a5a2 to f1d8f5f Compare February 25, 2025 09:59
@julianguinard julianguinard marked this pull request as ready for review February 25, 2025 10:33
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a paragraph below Parameter list explaining this new feature? Basically a gist of the code PR description would be great

@julianguinard julianguinard force-pushed the add-metrics-api-aggregation-from-kube-service-feature branch 3 times, most recently from 099b05b to 6bc8138 Compare April 28, 2025 09:55
@julianguinard
Copy link
Contributor Author

Could you please add a paragraph below Parameter list explaining this new feature? Basically a gist of the code PR description would be great

Hello @zroubalik , I just added a shorter version of the code PR description in a new paragraph for the metrics the docs here

@julianguinard julianguinard requested a review from zroubalik April 28, 2025 09:58
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the file for v2.18 instead of v2.17?

@julianguinard
Copy link
Contributor Author

Could you move this to the file for v2.18 instead of v2.17?

Sure, I closed this PR by accident & opened a new one here so doc is moved to 2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants