-
Notifications
You must be signed in to change notification settings - Fork 524
update metrics-api scaler doc related to fetching metrics from kubernetes service #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update metrics-api scaler doc related to fetching metrics from kubernetes service #1541
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
a90a5a2 to
f1d8f5f
Compare
zroubalik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a paragraph below Parameter list explaining this new feature? Basically a gist of the code PR description would be great
099b05b to
6bc8138
Compare
Hello @zroubalik , I just added a shorter version of the code PR description in a new paragraph for the metrics the docs here |
JorTurFer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to the file for v2.18 instead of v2.17?
6bc8138 to
26650dd
Compare
Sure, I closed this PR by accident & opened a new one here so doc is moved to 2.18 |
this related to the addition of
aggregateFromKubeServiceEndpointsandaggregationTypeparameters in PR 6565, used to fetch/aggregate metrics from a kubernetes service's list of endpointsChecklist