Fix Accessibility Violations for Social Media Buttons#1700
Merged
JorTurFer merged 2 commits intokedacore:mainfrom Jan 31, 2026
Merged
Fix Accessibility Violations for Social Media Buttons#1700JorTurFer merged 2 commits intokedacore:mainfrom
JorTurFer merged 2 commits intokedacore:mainfrom
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Signed-off-by: huangkevin-apr <huangkevinapr@outlook.com>
e6a99c5 to
c73d400
Compare
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves accessibility violations for icon-only social media links by adding accessible names via aria-label in the social buttons partial (Fixes #1699).
Changes:
- Add
aria-labelto social button<a>elements using the existing.namefield.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Member
|
Thanks a lot for the report and the fix! |
JorTurFer
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves 3 accessibility violations detected by the IBM Equal Access Accessibility Checker in the social buttons component. The fix adds accessible names to icon-only links by leveraging existing button data, ensuring screen reader users can identify the purpose of each social media button.

Why is this important?
When the purpose of a link is clear users can easily navigate links on the page without having to see the surrounding information for context.
Solution
Added
aria-labelattribute to the button links, utilizing the existing name property from the data structure:Why This Solution Is Elegant
This fix is particularly well-designed because it:
Leverages existing data: Uses the name property already present in the button configuration
Scales automatically: Any new social buttons added to the data will automatically have accessible names
Requires minimal changes: Single-line modification fixes all button instances
Maintains consistency: All buttons use the same accessibility pattern
No duplication: Doesn't require hard-coding labels for each button type
Checklist
Fixes #1699