docs(kafka): clarify earliest-policy lag excludes retention-deleted messages - #1825
Open
Nikko-Foti wants to merge 2 commits into
Open
docs(kafka): clarify earliest-policy lag excludes retention-deleted messages#1825Nikko-Foti wants to merge 2 commits into
Nikko-Foti wants to merge 2 commits into
Conversation
…essages Signed-off-by: Nikko Foti <nfoti201@gmail.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Open
8 tasks
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
…e to partitions with retained messages Signed-off-by: Nikko Foti <nfoti201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
earliestoffset reset policy description for the Kafka scaler to match kedacore/keda#7937.With no committed offset and
offsetResetPolicy: earliest, the scaler previously reported the topic's last offset as lag, which counted messages retention had already deleted. It now reports the messages still retained, i.e. last offset minus earliest available offset. Only the 2.21 docs are changed, since earlier versions describe shipped behavior.Checklist
Relates to kedacore/keda#7936
Relates to kedacore/keda#7937