-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using secretRef for hashicorpVault auth #6143
base: main
Are you sure you want to change the base?
Allow using secretRef for hashicorpVault auth #6143
Conversation
0d3435c
to
bbae0b0
Compare
59d5df0
to
dce9397
Compare
}, | ||
} | ||
vaultHandler := NewHashicorpVaultHandler(&vault) | ||
err := vaultHandler.Initialize(context.TODO(), nil, logf.Log.WithName("test"), "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
0003f49
to
7d4775c
Compare
I see that you have pushed changes this week, are you still working or I can review it? |
@JorTurFer I think I'm done. Could you help to review it? So sorry I had a busy Christmas so I'm trying to work on the E2E test as you mentioned in the previous stand up |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Allow referring to a k8s secret that contain hashicorp Vault token. Similar to AzureKeyVault and AWSSecretManager https://keda.sh/docs/2.15/concepts/authentication/#re-use-credentials-and-delegate-auth-with-triggerauthentication
TODO
Checklist
Fixes #6026