-
Notifications
You must be signed in to change notification settings - Fork 1.3k
KEDA Hashicorp vault service account token request #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEDA Hashicorp vault service account token request #6446
Conversation
Signed-off-by: Bojan Zelic <[email protected]>
…ce-account-token-request
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
|
Could you also add some e2e tests? |
a8b484a to
a5afafe
Compare
Signed-off-by: Bojan Zelic <[email protected]>
a5afafe to
bfa2613
Compare
|
@SpiritZhou I fixed the PR from your comments and updated the helmchart & documentation 🙏 please take a look whenever you get a chance. |
|
/run-e2e hashicorp |
JorTurFer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only point I have is the one related with the other PR adding support for the same API for other usage
…ce-account-token-request
…ce-account-token-request
Signed-off-by: Bojan Zelic <[email protected]>
…ub.com:BojanZelic/keda into keda-vault-service-account-token-request
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
wozniakjan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
|
/run-e2e secret |
Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Bojan Zelic <[email protected]>
|
@wozniakjan I had a file rename as part of the PR that shouldn't have been there (fixed in f414b39 ) and the e2e tests were failing, I think they should be good now 🤞 |
|
/run-e2e hashicorp_vault |
|
@zroubalik any thoughts for getting this PR merged? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
…ce-account-token-request
…ub.com:BojanZelic/keda into keda-vault-service-account-token-request
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
|
/run-e2e hashicorp_vault |
zroubalik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once docs PR is resolved, we can merge.
Thanks!
|
/run-e2e hashicorp_vault |
|
Hi @BojanZelic , i see there is a merge conflict |
Signed-off-by: Bojan Zelic <[email protected]>
…ce-account-token-request Signed-off-by: Bojan Zelic <[email protected]>
…ub.com:BojanZelic/keda into keda-vault-service-account-token-request Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
|
/run-e2e hashicorp_vault |
* General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * add e2e test Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> * Update pkg/scaling/resolver/hashicorpvault_handler.go Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Bojan Zelic <[email protected]> * Rename patch_operator.yaml to patch_operator.yml Signed-off-by: Bojan Zelic <[email protected]> * fix order of changelog Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
* General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * add e2e test Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> * Update pkg/scaling/resolver/hashicorpvault_handler.go Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Bojan Zelic <[email protected]> * Rename patch_operator.yaml to patch_operator.yml Signed-off-by: Bojan Zelic <[email protected]> * fix order of changelog Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Dmitriy Altuhov <[email protected]>
* General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * General: Vault authentication via cross-namespace service accounts Signed-off-by: Bojan Zelic <[email protected]> * add e2e test Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * combine logic to retreive service account tokens Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> * Update pkg/scaling/resolver/hashicorpvault_handler.go Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Bojan Zelic <[email protected]> * Rename patch_operator.yaml to patch_operator.yml Signed-off-by: Bojan Zelic <[email protected]> * fix order of changelog Signed-off-by: Bojan Zelic <[email protected]> * Update CHANGELOG.md Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
Allows users to authenticate to vault via a service account in the scaledObject's namespace;
ex:
would use the JWT token from the
defaultservice account in themynamespacenamespaceThis allows users to set more fine-grained permissions in vault.
Checklist
Fixes # #6153
Relates to #