New Solace Direct Messaging Scaler #6546

alfonso-chacon · 2025-02-12T23:45:39Z

New Solace Direct Messaging Scaler Added

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Fixes #6545
[#1537] (kedacore/keda-docs#1537) - Documentation

Signed-off-by: Alfonso Chacón <[email protected]>

…scarded messages while scaling up Signed-off-by: Alfonso Chacón <[email protected]>

- Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <[email protected]>

Signed-off-by: Alfonso Chacón <[email protected]>

Signed-off-by: alfonso-chacon <[email protected]>

pkg/scalers/solace_dm_scaler.go

Signed-off-by: Alfonso Chacón <[email protected]>

* Code Cleanup - CodeQL/StaticChecks

Signed-off-by: Alfonso Chacón <[email protected]>

* Code cleanup /golangci-lint

Signed-off-by: Alfonso Chacón <[email protected]>

pkg/scalers/solace_dm_scaler.go

JorTurFer · 2025-02-14T22:45:51Z

/run-e2e solace_dm
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

Signed-off-by: Alfonso Chacón <[email protected]>

JorTurFer · 2025-02-15T22:26:24Z

/run-e2e solace_dm
Update: You can check the progress here

alfonso-chacon · 2025-02-17T15:50:15Z

@JorTurFer Is there anything I can do for the failed check? its complaining about a timeout in a API

=== FAIL: pkg/scalers TestPredictKubeGetMetricSpecForScaling (3.00s)
2025/02/17 08:01:26 🚀 starting mock grpc server. On host 0.0.0.0, with port: 44809
predictkube_scaler_test.go:187:
Error Trace: /__w/keda/keda/pkg/scalers/predictkube_scaler_test.go:187
Error: Received unexpected error:
error create Prometheus client and API objects: Get "http://demo.robustperception.io:9090/api/v1/status/runtimeinfo": dialing to the given TCP address timed out
Test: TestPredictKubeGetMetricSpecForScaling
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x277cad8]

JorTurFer · 2025-02-17T19:51:27Z

Yeah, totally unrelated with your change, this PR fixes it -> #6553

pkg/scalers/solace_dm_scaler.go

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

- Move regex to pkg level - Remove unnecessary struct and interface Signed-off-by: Alfonso Chacón <[email protected]>

zroubalik · 2025-02-18T10:34:12Z

/run-e2e solace_dm
Update: You can check the progress here

pkg/scalers/solace_dm_scaler.go

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

zroubalik · 2025-02-25T09:07:42Z

/run-e2e solace_dm
Update: You can check the progress here

Signed-off-by: Alfonso Chacón <[email protected]>

alfonso-chacon · 2025-03-24T18:01:53Z

@zroubalik @JorTurFer Hi guys, not to be pushy or something, is there any chance this scaler could be included in the 2.17 version? I just want to know how to manage expectations with possible users :D

zroubalik · 2025-03-26T19:13:14Z

@zroubalik @JorTurFer Hi guys, not to be pushy or something, is there any chance this scaler could be included in the 2.17 version? I just want to know how to manage expectations with possible users :D

We will try to do our best here :) (at least me, not sure about @JorTurFer 😄 😄 )

Signed-off-by: alfonso-chacon <[email protected]>

alfonso-chacon added 11 commits January 31, 2025 22:45

* Solace Direct Messaging Scaler

2eab88e

Signed-off-by: Alfonso Chacón <[email protected]>

Fix D-1 queue calculation

e7a401b

Signed-off-by: Alfonso Chacón <[email protected]>

Refactor variables

5bc9f84

Signed-off-by: Alfonso Chacón <[email protected]>

Inlcude D-1 messages in calculation

a4569b4

Signed-off-by: Alfonso Chacón <[email protected]>

Modify url to be able to use https protocol

5cd2c34

Signed-off-by: Alfonso Chacón <[email protected]>

Added UnsafeSSL parameter to avoid SSL validations

22e01b5

Signed-off-by: Alfonso Chacón <[email protected]>

Added a factor to multiply the weight of queues messages to reduce di…

c805b34

…scarded messages while scaling up Signed-off-by: Alfonso Chacón <[email protected]>

Refactor and enhancements

6dabb42

- Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <[email protected]>

* Scaler E2E testing

81cdd14

Signed-off-by: Alfonso Chacón <[email protected]>

Adding New Solace Direct Messaging Scaler in CHANGELOG.md

4a9658b

Signed-off-by: Alfonso Chacón <[email protected]>

Merge branch 'main' into changelog-merge

660f78d

Signed-off-by: alfonso-chacon <[email protected]>

github-advanced-security bot found potential problems Feb 13, 2025

View reviewed changes

pkg/scalers/solace_dm_scaler.go Fixed Show fixed Hide fixed

alfonso-chacon added 6 commits February 12, 2025 21:00

* Code Cleanup - CodeQL/StaticChecks

b387be3

Signed-off-by: Alfonso Chacón <[email protected]>

Merge pull request #1 from alfonso-chacon/main

94ebcb4

* Code Cleanup - CodeQL/StaticChecks

* Code cleanup /golangci-lint

df7168a

Signed-off-by: Alfonso Chacón <[email protected]>

Merge pull request #2 from alfonso-chacon/main

87fbac5

* Code cleanup /golangci-lint

* Correct order in CHANGELOG.md

9423f60

Signed-off-by: Alfonso Chacón <[email protected]>

* Remove trailing white spaces

34c283a

Signed-off-by: Alfonso Chacón <[email protected]>

alfonso-chacon marked this pull request as ready for review February 13, 2025 04:27

alfonso-chacon requested a review from a team as a code owner February 13, 2025 04:27

JorTurFer reviewed Feb 14, 2025

View reviewed changes

alfonso-chacon and others added 6 commits February 15, 2025 00:37

* Cleanup code - remove comment

03baab6

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Cleanup code - remove comment

bfb0c59

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Cleanup code - remove comment

886e402

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Cleanup code - change log level

0dd0153

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* E2E tests - reduce time in scale down cfg

3035023

Signed-off-by: Alfonso Chacón <[email protected]>

* E2E fix typo

2fa0250

Signed-off-by: Alfonso Chacón <[email protected]>

JorTurFer reviewed Feb 17, 2025

View reviewed changes

alfonso-chacon and others added 5 commits February 17, 2025 14:32

* Avoid read secrets from metadata

8a8969b

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Remove constant used once

8c5efdb

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Remove constant used once on logger init

459fdd9

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Code cleanup recommendations

68b2e46

- Move regex to pkg level - Remove unnecessary struct and interface Signed-off-by: Alfonso Chacón <[email protected]>

Merge branch 'main' into changelog-merge

6886df3

zroubalik reviewed Feb 18, 2025

View reviewed changes

pkg/scalers/solace_dm_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/solace_dm_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/solace_dm_scaler.go Show resolved Hide resolved

alfonso-chacon and others added 4 commits February 18, 2025 08:10

* Code cleanup

3e20215

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

* Code cleanup

803f6f0

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: alfonso-chacon <[email protected]>

Merge branch 'main' into changelog-merge

583bc01

Merge branch 'main' into changelog-merge

24052ce

alfonso-chacon added 8 commits March 4, 2025 10:29

Merge branch 'main' into changelog-merge

6f2914a

Merge branch 'main' into changelog-merge

22f48e6

* Updated to sync with other sol scaler

135826a

Signed-off-by: Alfonso Chacón <[email protected]>

* Remove unnecessary trailing newline

c2e437b

Signed-off-by: Alfonso Chacón <[email protected]>

Merge branch 'main' into changelog-merge

7623222

Merge branch 'main' into changelog-merge

240e6c1

Merge branch 'main' into changelog-merge

8528269

Merge branch 'main' into changelog-merge

78d5c18

zroubalik mentioned this pull request Mar 26, 2025

Release: 2.17.0 #6502

Open

40 tasks

alfonso-chacon added 3 commits March 26, 2025 22:36

Merge branch 'main' into changelog-merge

bb95b4c

Merge branch 'main' into changelog-merge

856f5ce

Merge branch 'main' into changelog-merge

c84984f

Signed-off-by: alfonso-chacon <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Solace Direct Messaging Scaler #6546

New Solace Direct Messaging Scaler #6546

alfonso-chacon commented Feb 12, 2025 •

edited by zroubalik

Loading

JorTurFer commented Feb 14, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 15, 2025 •

edited by github-actions bot

Loading

alfonso-chacon commented Feb 17, 2025

JorTurFer commented Feb 17, 2025

zroubalik commented Feb 18, 2025 •

edited by github-actions bot

Loading

zroubalik commented Feb 25, 2025 •

edited by github-actions bot

Loading

alfonso-chacon commented Mar 24, 2025

zroubalik commented Mar 26, 2025

New Solace Direct Messaging Scaler #6546

Are you sure you want to change the base?

New Solace Direct Messaging Scaler #6546

Conversation

alfonso-chacon commented Feb 12, 2025 • edited by zroubalik Loading

Checklist

JorTurFer commented Feb 14, 2025 • edited by github-actions bot Loading

JorTurFer commented Feb 15, 2025 • edited by github-actions bot Loading

alfonso-chacon commented Feb 17, 2025

JorTurFer commented Feb 17, 2025

zroubalik commented Feb 18, 2025 • edited by github-actions bot Loading

zroubalik commented Feb 25, 2025 • edited by github-actions bot Loading

alfonso-chacon commented Mar 24, 2025

zroubalik commented Mar 26, 2025

alfonso-chacon commented Feb 12, 2025 •

edited by zroubalik

Loading

JorTurFer commented Feb 14, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 15, 2025 •

edited by github-actions bot

Loading

zroubalik commented Feb 18, 2025 •

edited by github-actions bot

Loading

zroubalik commented Feb 25, 2025 •

edited by github-actions bot

Loading