Skip to content

Comments

feat: deprecate minMetricValue in Huawei Cloudeye scaler#7445

Open
rickbrouwer wants to merge 1 commit intokedacore:mainfrom
rickbrouwer:huawei
Open

feat: deprecate minMetricValue in Huawei Cloudeye scaler#7445
rickbrouwer wants to merge 1 commit intokedacore:mainfrom
rickbrouwer:huawei

Conversation

@rickbrouwer
Copy link
Member

deprecate minMetricValue in Huawei Cloudeye scaler

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added (if applicable)
  • Ensure make generate-scalers-schema has been run to update any outdated generated files
  • Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #7436

@rickbrouwer rickbrouwer requested a review from a team as a code owner February 6, 2026 17:10
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested a review from a team February 6, 2026 17:10
@snyk-io
Copy link

snyk-io bot commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rickbrouwer
Copy link
Member Author

There is no e2e test for Huawei Cloudeye scaler, so I skip the e2e.

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer added the Awaiting/2nd-approval This PR needs one more approval review label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting/2nd-approval This PR needs one more approval review breaking-change skip-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants