Skip to content

Comments

feat: create oauth2 auth trigger, integrate it with rabbitmq scaler#7454

Open
KyriosGN0 wants to merge 9 commits intokedacore:mainfrom
KyriosGN0:rmq-oauth2
Open

feat: create oauth2 auth trigger, integrate it with rabbitmq scaler#7454
KyriosGN0 wants to merge 9 commits intokedacore:mainfrom
KyriosGN0:rmq-oauth2

Conversation

@KyriosGN0
Copy link

@KyriosGN0 KyriosGN0 commented Feb 14, 2026

Provide a description of what has been changed

This PR add a new OAuth2 spec to to TriggerAuth crd, this spec will generate an access token that is returned to the scaler.
This PR also integrates this new spec to RabbitMQ scaler (currently only for http connection)
this allows people who use RabbitMQ with OAuth to use a timed access token instead of username/password

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added (if applicable)
  • Ensure make generate-scalers-schema has been run to update any outdated generated files
  • Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #7379

Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0 KyriosGN0 requested a review from a team as a code owner February 14, 2026 13:26
@github-actions
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@snyk-io
Copy link

snyk-io bot commented Feb 14, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@keda-automation keda-automation requested a review from a team February 14, 2026 13:27
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@keda-automation keda-automation requested a review from a team February 16, 2026 19:09
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also open docs PR (documenting both new TriggerAuth config and RabbitMQ)?

// versions:
// - protoc-gen-go-grpc v1.6.0
// - protoc v6.33.5
// - protoc v6.33.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please omit these non related changes from the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants