feat: create oauth2 auth trigger, integrate it with rabbitmq scaler#7454
feat: create oauth2 auth trigger, integrate it with rabbitmq scaler#7454KyriosGN0 wants to merge 9 commits intokedacore:mainfrom
Conversation
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: AvivGuiser <avivguiser@gmail.com>
zroubalik
left a comment
There was a problem hiding this comment.
Could you please also open docs PR (documenting both new TriggerAuth config and RabbitMQ)?
| // versions: | ||
| // - protoc-gen-go-grpc v1.6.0 | ||
| // - protoc v6.33.5 | ||
| // - protoc v6.33.4 |
There was a problem hiding this comment.
Could you please omit these non related changes from the PR?
Provide a description of what has been changed
This PR add a new OAuth2 spec to to TriggerAuth crd, this spec will generate an access token that is returned to the scaler.
This PR also integrates this new spec to RabbitMQ scaler (currently only for http connection)
this allows people who use RabbitMQ with OAuth to use a timed access token instead of username/password
Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #
Relates to #7379