chore: bump k8s.io & controller-runtime dependencies by mycrEEpy · Pull Request #7455 · kedacore/keda

mycrEEpy · 2026-02-15T11:31:22Z

… and:

implement generics in webhooks
implement new events recorder
add package action for common event actions
update k8s.io/* to v0.35.1
update sigs.k8s.io/controller-runtime to v0.23.1
update github.com/prometheus/common to v0.67.5 (required for expfmt.NewTextParser)

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

…nerics in webhooks * update k8s.io/* to v0.35.1 * update sigs.k8s.io/controller-runtime to v0.23.1 Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

github-actions · 2026-02-15T11:31:32Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io · 2026-02-15T11:32:27Z

⚠️ Snyk checks are incomplete.

Status	Scanner	Critical	High	Medium	Low	Total (0)
⚠️	Open Source Security	0	0	0	0	See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

required for expfmt.NewTextParser Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy

Should we ignore the deprecation of GetEventRecorderFor for now to not bloat this PR?

mycrEEpy · 2026-02-15T21:29:46Z

pkg/scalers/metrics_api_scaler.go


 	reader := strings.NewReader(bodyStr)
-	familiesParser := expfmt.TextParser{}
+	familiesParser := expfmt.NewTextParser(model.LegacyValidation)


Also, unsure about which ValidationScheme to use here..

Which are the options?

// LegacyValidation is a setting that requires that all metric and label names // conform to the original Prometheus character requirements described by // MetricNameRE and LabelNameRE. LegacyValidation // UTF8Validation only requires that metric and label names be valid UTF-8 // strings. UTF8Validation

JorTurFer · 2026-02-15T22:20:33Z

go.mod

 	github.com/chzyer/logex => github.com/chzyer/logex v1.2.1

-	// pin k8s.io to v0.34.3 & sigs.k8s.io/controller-runtime to v0.22.4
+	// pin k8s.io to v0.35.1 & sigs.k8s.io/controller-runtime to v0.23.1


ensure that these deps have the same version outside the replace please

They are all on v0.35.1 outside of the replace.
The controller-runtime already was on v0.23.1.
I have also fixed the client-go version which was set to v1.5.2, an old, deprecated version.

JorTurFer · 2026-02-15T22:21:52Z

Should we ignore the deprecation of GetEventRecorderFor for now to not bloat this PR?

if it's possible, let's solve it here

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

semgrep-code-kedacore · 2026-02-16T23:30:05Z

pkg/scaling/scalers_builder.go

@@ -107,7 +108,7 @@ func (h *scaleHandler) buildScalers(ctx context.Context, withTriggers *kedav1alp
 			return nil, err
 		}


Semgrep identified an issue in your code:
Variable scaler is likely modified and later used on error. In some cases this could result in panics due to a nil dereference

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by invalid-usage-of-modified-variable.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy · 2026-02-16T23:54:31Z

Should we ignore the deprecation of GetEventRecorderFor for now to not bloat this PR?

if it's possible, let's solve it here

The new events.EventRecorder only exposes Eventf with two new parameters related runtime.Object and action string. I've set related to nil everywhere for now to keep it simple. For action I've added a new package with constants to represent common actions like create, update & delete.

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy added 2 commits February 15, 2026 12:20

chore: bump k8s.io & controller-runtime dependencies and implement ge…

07aa6a6

…nerics in webhooks * update k8s.io/* to v0.35.1 * update sigs.k8s.io/controller-runtime to v0.23.1 Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

chore: make generate-scalers-schema

24f2318

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy requested a review from a team as a code owner February 15, 2026 11:31

keda-automation requested a review from a team February 15, 2026 11:31

mycrEEpy marked this pull request as draft February 15, 2026 12:18

mycrEEpy added 5 commits February 15, 2026 21:37

chore(deps): update github.com/prometheus/common to v0.67.5

e2f9bc2

required for expfmt.NewTextParser Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

fix: missing vendored file

24cf61c

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

chore: make clientset-generate

db40770

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

chore: make manifests

e6f24fa

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

fix(scalers/metrics): use expfmt.NewTextParser with LegacyValidation

c2d00c5

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy commented Feb 15, 2026

View reviewed changes

mycrEEpy marked this pull request as ready for review February 15, 2026 21:37

JorTurFer reviewed Feb 15, 2026

View reviewed changes

mycrEEpy added 2 commits February 17, 2026 00:02

feat: use new events recorder

a270f13

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

feat: implement event actions

121e3b4

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

keda-automation requested a review from a team February 16, 2026 23:28

semgrep-code-kedacore bot reviewed Feb 16, 2026

View reviewed changes

mycrEEpy added 2 commits February 17, 2026 00:37

fix: gci lint

0e51de8

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

feat: update rbac to use events.k8s.io

eace820

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy added 5 commits February 17, 2026 00:56

fix: import lints

90fdbad

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

docs: update changelog

fe50e28

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

fix: import lints

f531857

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

fix: sort changelog

cfd4ca0

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

fix: run golangci-lint fmt

3fd97ae

Signed-off-by: Tobias <bvrcreepyx@hotmail.de>

mycrEEpy force-pushed the update-controller-runtime branch from 3c30756 to 3fd97ae Compare February 17, 2026 00:28

halamix2 mentioned this pull request Feb 18, 2026

Bump Keda to 2.19.0 kyma-project/keda-manager#802

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: bump k8s.io & controller-runtime dependencies#7455

chore: bump k8s.io & controller-runtime dependencies#7455
mycrEEpy wants to merge 16 commits intokedacore:mainfrom
mycrEEpy:update-controller-runtime

mycrEEpy commented Feb 15, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

snyk-io bot commented Feb 15, 2026 •

edited

Loading

Uh oh!

mycrEEpy left a comment

Uh oh!

mycrEEpy Feb 15, 2026 •

edited

Loading

Uh oh!

JorTurFer Feb 15, 2026

Uh oh!

mycrEEpy Feb 16, 2026

Uh oh!

JorTurFer Feb 15, 2026

Uh oh!

mycrEEpy Feb 16, 2026

Uh oh!

JorTurFer commented Feb 15, 2026

Uh oh!

semgrep-code-kedacore bot Feb 16, 2026

Uh oh!

mycrEEpy commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -107,7 +108,7 @@ func (h scaleHandler) buildScalers(ctx context.Context, withTriggers kedav1alp
		return nil, err
		}

Comments

Conversation

mycrEEpy commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

snyk-io bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Snyk checks are incomplete.

Uh oh!

mycrEEpy left a comment

Choose a reason for hiding this comment

Uh oh!

mycrEEpy Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JorTurFer Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

mycrEEpy Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

JorTurFer Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

mycrEEpy Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

JorTurFer commented Feb 15, 2026

Uh oh!

semgrep-code-kedacore bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

mycrEEpy commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mycrEEpy commented Feb 15, 2026 •

edited

Loading

snyk-io bot commented Feb 15, 2026 •

edited

Loading

mycrEEpy Feb 15, 2026 •

edited

Loading