[feat] Implement the functionality of removeMembers#36
Open
Rana718 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Hey @Rana718 could you do scarb fmt and also fix the error while trying to do snforge test |
Author
|
Thanks for the feedback! I've just pushed the latest changes that include running scarb fmt to format the code. I also fixed the errors encountered during snforge test, and everything should be working smoothly now. |
Collaborator
|
@Rana718 Still been getting the same error could you check on it ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the remove_members function for the Registry contract as outlined in Issue #6. The function has been adapted to use u256 instead of bytes32 and is designed to revoke the specified members' access from a profile.
Changes Made: