Skip to content

[feat] Implement the functionality of removeMembers#36

Open
Rana718 wants to merge 2 commits into
keep-starknet-strange:mainfrom
Rana718:remove_members
Open

[feat] Implement the functionality of removeMembers#36
Rana718 wants to merge 2 commits into
keep-starknet-strange:mainfrom
Rana718:remove_members

Conversation

@Rana718

@Rana718 Rana718 commented Aug 24, 2024

Copy link
Copy Markdown

This pull request implements the remove_members function for the Registry contract as outlined in Issue #6. The function has been adapted to use u256 instead of bytes32 and is designed to revoke the specified members' access from a profile.

Changes Made:

  • Implemented the remove_members function in Cairo.
  • Converted profile_Id from u256 to felt252 for compatibility.
  • Iterated through the members array to revoke their roles using self.accessControl._revoke_role.
  • Updated member_length with the length of the members array.

@Akashneelesh

Copy link
Copy Markdown
Collaborator

Hey @Rana718 could you do scarb fmt and also fix the error while trying to do snforge test

@Rana718

Rana718 commented Aug 28, 2024

Copy link
Copy Markdown
Author

Thanks for the feedback! I've just pushed the latest changes that include running scarb fmt to format the code. I also fixed the errors encountered during snforge test, and everything should be working smoothly now.

@Akashneelesh

Copy link
Copy Markdown
Collaborator

@Rana718 Still been getting the same error could you check on it ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants