[codex] Expose typed generate-pie errors#526
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StateUpdateErrorthroughgenerate_pie::errorso downstream callers can match it structurallyBlockProcessingErroras the typed source insidePieGenerationError::BlockProcessingWhy
This is a follow-up to #525.
The previous change introduced structured
StateUpdateErrorandBlockProcessingErrorvariants, but two API boundaries still erased that structure for downstream users:StateUpdateErrorlived in a private module, so external callers could not matchStateUpdateError::RpcErrorPieGenerationError::BlockProcessingstored its source asBox<dyn Error + Send + Sync>, which forced downstream callers to downcast instead of pattern matching directlyThis follow-up makes the typed error model usable to consumers such as the orchestrator.
Validation
cargo fmt --allcargo test -p generate-piecargo test -p generate-pie --test public_error_apisource /Users/prakhar/work/karnot/snos/sequencer_venv/bin/activate && cargo clippy -p generate-pie --all-features --tests --no-deps -- -D warnings